Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override resultAggregator property in test formats #6590

Merged
merged 1 commit into from Oct 30, 2022

Conversation

Naktibalda
Copy link
Member

Fixes #6587

@yesdevnull
Copy link
Contributor

Exceptionally trivial patch for a test I had written locally when testing this problem originally:

Index: tests/data/exception_in_before/tests/_support/Helper/Unit.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/tests/data/exception_in_before/tests/_support/Helper/Unit.php b/tests/data/exception_in_before/tests/_support/Helper/Unit.php
--- a/tests/data/exception_in_before/tests/_support/Helper/Unit.php	(revision 3c27deb02abfc9d94f52669a584c8a88b58faed1)
+++ b/tests/data/exception_in_before/tests/_support/Helper/Unit.php	(date 1666412498428)
@@ -8,4 +8,9 @@
     {
         throw new \Exception('in before');
     }
+
+    public function _failed(\Codeception\TestInterface $test, \Exception $fail)
+    {
+        $this->assertInstanceOf(\Codeception\ResultAggregator::class, $test->getResultAggregator());
+    }
 }

@Naktibalda Naktibalda merged commit d2e403f into 5.0 Oct 30, 2022
@Naktibalda Naktibalda deleted the result-aggregator-cleanup branch October 30, 2022 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to retrieve ResultAggregator from TestInterface
3 participants