suggestion on missing modules #6079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks really nice to me! Thank you 👍 Yes, please add some tests into ModuleContainerTest |
c33s
changed the title
|
@DavertMik ready to merge. |
Naktibalda
reviewed
Jan 15, 2021
Because it was hard to read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had the problem that i wasn't able to connect to a module, which i included in the config. took quite a while to debug. it was a simple diff in the case
LockPickvsLockpickso i added some code to add a suggestion which module could be meant to the error message.
vs
have not adapted any tests yet, wanted to wait for comments if you would merge this before.