Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use path resolver for bootstrap file detection #5725

Merged
merged 1 commit into from Oct 18, 2019
Merged

Use path resolver for bootstrap file detection #5725

merged 1 commit into from Oct 18, 2019

Conversation

laoneo
Copy link
Contributor

@laoneo laoneo commented Oct 16, 2019

Somehow I got the following error:
Call to undefined function Codeception\codecept_is_path_absolute() in /project/tests/vendor/codeception/codeception/src/Codeception/Configuration.php:278

This patch uses the PathResolver.

@laoneo
Copy link
Contributor Author

laoneo commented Oct 16, 2019

Mot sure why travis failed, but it looks like that the error is not related to the patch.

Copy link
Member

@Naktibalda Naktibalda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
The failed build passed on second run.

@Naktibalda Naktibalda merged commit 82d7aaa into Codeception:3.1 Oct 18, 2019
@laoneo laoneo deleted the configuration/bootstrap branch October 18, 2019 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants