Avoid removing required fields in cookies. #5470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naktibalda
approved these changes
Apr 16, 2019
|
Thanks! |
DavertMik
pushed a commit
that referenced
this pull request
Apr 23, 2019
* Proposed solution for #5457 gherkin scenarios not loaded from group file (#5458) * proposed solution for #5457 gherkin scenarios not loaded from group file * testing for getMetaData method before calling it in GroupManager * reformatting if statement to appease nitpick * adding tests for #5457 * Update LOCAL_FILE constant for new version of phpseclib (#5461) * Using button formaction attr in proceedSubmitForm method (#5440) * Using button formaction attr in proceedSubmitForm method (AcceptanceTesterActions::submitForm) * Update InnerBrowser.php * Avoid removing required fields in cookies. (#5470)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cookie with ['name' => 'test', 'value' => 0] would get it's value stripped, causing an "undefined index: value" notice in php-webdriver's Cookie.php