Error with chromedriver 2.46 #5401

JorisVanEijden · 2019-02-20T13:55:12Z

What are you trying to achieve?

Use chromedriver to run tests.

What do you get instead?

[Facebook\WebDriver\Exception\UnrecognizedExceptionException] invalid argument: invalid 'expiry'
(Session info: chrome=72.0.3626.81)
(Driver info: chromedriver=2.46.628388 (4a34a70827ac54148e092aafb70504c4ea7ae926),platform=Linux 4.9.125-linuxkit x86_64)

#1  /var/www/html/vendor/facebook/webdriver/lib/Exception/WebDriverException.php:158
#2  /var/www/html/vendor/facebook/webdriver/lib/Remote/HttpCommandExecutor.php:326
#3  /var/www/html/vendor/facebook/webdriver/lib/Remote/RemoteWebDriver.php:547
#4  /var/www/html/vendor/facebook/webdriver/lib/Remote/RemoteExecuteMethod.php:40
#5  /var/www/html/vendor/facebook/webdriver/lib/WebDriverOptions.php:55
#6  Codeception\Module\WebDriver->loadSessionSnapshot

Details

Codeception version: 2.5.3
PHP Version: 7.1
Operating System: Any
Installation type: Composer
Suite configuration:

modules:
    enabled:
        -
          WebDriver:
            browser: chrome
            capabilities:
              javascriptEnabled: true
              resourceTimeout: 300000
            host: %WEBDRIVER_HOST%
            url: %WEBSITE_URL%

Chromedriver 2.45 works fine.
In 2.46 they added extra cookie validation (https://chromium-review.googlesource.com/c/chromium/src/+/1366925)

The text was updated successfully, but these errors were encountered:

Naktibalda · 2019-02-20T16:57:21Z

Isn't it a bug of Chromedriver then?
I've seen this issue few weeks ago and it looked like Chromedriver broke setCookie in legacy mode completely, but facebook/php-webdriver library does not support W3C mode yet.

…not null which fails in chromedriver 2.46

…chromedriver happy.

OneEyedSpaceFish · 2019-02-21T09:49:42Z

@JorisVanEijden
Imo, if this is a bug with Chromedriver, then it's worth raising an issue / PR with them instead of adding a workaround solution in CC.

JorisVanEijden · 2019-02-21T09:58:25Z

I don't think it's a bug in Chromedriver to state that null is an invalid value for those cookie fields.
From https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol I would also expect null to be an invalid value.
https://w3c.github.io/webdriver/#add-cookie basically says the same.

I could raise a PR with Facebook webdriver to refuse cookies with null values. But then you still need this PR for Codeception.

Edit: Facebook php-webdriver issue: php-webdriver/php-webdriver#626

JorisVanEijden · 2019-02-25T12:27:39Z

I've created php-webdriver/php-webdriver#627 to stop php-webdriver from passing the invalid cookie values it gets from Codeception to chromedriver.

jeckel · 2019-03-17T10:42:08Z

I'm not sure I understand this issue...

Tell me if I'm wrong :

chrome updated his setCookie and broke legacy compatibility (something linked to default values in setCookie ? like path or expiry when this values are null)
webdriver (maintained by facebook) haven't been updated to handle this change correctly, and in some cases, it still call setCookie with null value for some parameters
codeception, when using webdriver don't set this values and expect WebDriver to handle them correctly with some defaults

Am I correct ?

Kender2 · 2019-03-17T10:55:41Z

cookie specs say values should not be null and chromedriver 2.46 started enforcing that
webdriver defaults to null cookie values for missing values
codeception does not supply defaults for cookie values

So yes.

jeckel · 2019-03-17T11:02:43Z

@Kender2 Great ! thanks

Then what's next ? this commit from @JorisVanEijden seems good to me, is there anything against adding default values in CC ?

JorisVanEijden@ec2fc73

reinholdfuereder · 2019-03-19T11:50:56Z

I tend to also see it like @jeckel and hope for a new (minor?) Codeception version release with this fix/workaround -- especially considering the lack of responses/actions on @JorisVanEijden commitment in
php-webdriver/php-webdriver#626 and/or php-webdriver/php-webdriver#627

Would it even hurt if Codeception sets this default cookie values, once facebook/php-webdriver would have a fix too?

Naktibalda · 2019-03-19T17:14:57Z

facebook/php-webdriver looks completely unmaintained since June last year.

I will merge workaroud before next release.

reinholdfuereder · 2019-03-20T07:05:50Z

@Naktibalda Thanks (in advance)!

Please note that I just assume that @JorisVanEijden fix solves the problem as I have not tested it at all, and neither have expert knowledge; but the changes definitely look good with respect to the failure symptoms ;-)

Rather unrelated, except that it is about "facebook/php-webdriver"

The situation around "facebook/php-webdriver" especially with respect to Firefox and W3C protocol actually makes me a little bit nervous too; although there is (or was) quite some work done, I am not sure how active/promising it is.

Can I test with new Selenium+Firefox? #5083 "Can I test with new Selenium+Firefox?"
"facebook/php-webdriver"
- W3C WebDriver protocol support php-webdriver/php-webdriver#469 "W3C WebDriver protocol support"
  - https://github.com/facebook/php-webdriver/wiki/JsonWireProtocol-vs.-W3C-WebDriver
- PHP Notice: Undefined index: ELEMENT error occured when I test with firefox browser php-webdriver/php-webdriver#492
- W3C-compliant implementation, native geckodriver support php-webdriver/php-webdriver#560 "Partial W3C implementation, native geckodriver support" ... PR that was actively worked on from mid April to mid October
- W3c php-webdriver/php-webdriver#599 "W3C" ... Another PR for this
Interesting comments on "minkphp/MinkSelenium2Driver"
- Support the W3C webdriver spec minkphp/MinkSelenium2Driver#293 "Support the W3C webdriver spec" ... recommends Facebook "php-webdriver" (I think)
- [WIP] Facebook driver minkphp/MinkSelenium2Driver#304 "[WIP] Facebook driver" ... Or not "php-webdriver"!? See "Moving away from instaclick/php-webdriver to facebook/php-webdriver as first one is not supported (ZF2 Query Params #293 (comment))"

jeckel · 2019-03-20T07:39:27Z

I tested @JorisVanEijden fix on my side and it solved my issue

JorisVanEijden · 2019-03-20T07:46:36Z

I'm sorry, I have not continued with this after patching php-webdriver.

The workaround composer.json I use:

{
  "require-dev": {
    "codeception/codeception": "^2.0",
    "cweagans/composer-patches": "^1.0",
  },
  "extra": {
    "patches": {
      "facebook/webdriver": {
        "issue_626": "https://patch-diff.githubusercontent.com/raw/facebook/php-webdriver/pull/627.patch"
      }
    }
  }
}

I remember running into some strange issues with PR #5404 but I was unable to figure out if that was due to the PR, php-webdriver, chromedriver or even my test suite :(
Please test carefully.

jeckel · 2019-03-20T08:09:09Z

On my side, my test suite is really simple, then it might not be enough to validate this PR.

By the way, thanks for the tips to patch webdriver.

Naktibalda · 2019-03-23T18:44:46Z

Fixed in Codeception 2.5.5 which was released today.

JorisVanEijden · 2019-04-16T07:59:50Z

Ok, I figured out what the issue was.
The array_filter removes the value entry from the cookie when the value is an empty string or 0 (zero).
This will fail because value is a required field.

Created #5470 to fix it.

zfz1120 · 2019-07-31T14:38:17Z

expiry 格式变了。。。把float该为int即可。。。亲测

Naktibalda added the WebDriver label Feb 20, 2019

JorisVanEijden pushed a commit to JorisVanEijden/Codeception that referenced this issue Feb 21, 2019

Workaround for bug Codeception#5401 to ensure cookie expiry value is …

c4d21e3

…not null which fails in chromedriver 2.46

JorisVanEijden mentioned this issue Feb 21, 2019

Ensure cookie expiry value is not null #5404

Merged

JorisVanEijden pushed a commit to JorisVanEijden/Codeception that referenced this issue Feb 21, 2019

Workaround Codeception#5401 by supplying defaults to cookies to keep …

7151f82

…chromedriver happy.

Naktibalda mentioned this issue Mar 16, 2019

Invalid argument 'path' when using webdriver with coverage #5437

Closed

Naktibalda closed this as completed in ec2fc73 Mar 23, 2019

jschnurr mentioned this issue Jun 30, 2019

error with transfer_session_cookies_to_driver() tryolabs/requestium#41

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Error with chromedriver 2.46 #5401

Error with chromedriver 2.46 #5401

JorisVanEijden commented Feb 20, 2019 •

edited

Naktibalda commented Feb 20, 2019

OneEyedSpaceFish commented Feb 21, 2019

JorisVanEijden commented Feb 21, 2019 •

edited

JorisVanEijden commented Feb 25, 2019

jeckel commented Mar 17, 2019

Kender2 commented Mar 17, 2019

jeckel commented Mar 17, 2019

reinholdfuereder commented Mar 19, 2019

Naktibalda commented Mar 19, 2019

reinholdfuereder commented Mar 20, 2019

jeckel commented Mar 20, 2019

JorisVanEijden commented Mar 20, 2019

jeckel commented Mar 20, 2019 •

edited

Naktibalda commented Mar 23, 2019

JorisVanEijden commented Apr 16, 2019 •

edited

zfz1120 commented Jul 31, 2019 •

edited

Error with chromedriver 2.46 #5401

Error with chromedriver 2.46 #5401

Comments

JorisVanEijden commented Feb 20, 2019 • edited

What are you trying to achieve?

What do you get instead?

Details

Naktibalda commented Feb 20, 2019

OneEyedSpaceFish commented Feb 21, 2019

JorisVanEijden commented Feb 21, 2019 • edited

JorisVanEijden commented Feb 25, 2019

jeckel commented Mar 17, 2019

Kender2 commented Mar 17, 2019

jeckel commented Mar 17, 2019

reinholdfuereder commented Mar 19, 2019

Naktibalda commented Mar 19, 2019

reinholdfuereder commented Mar 20, 2019

Rather unrelated, except that it is about "facebook/php-webdriver"

jeckel commented Mar 20, 2019

JorisVanEijden commented Mar 20, 2019

jeckel commented Mar 20, 2019 • edited

Naktibalda commented Mar 23, 2019

JorisVanEijden commented Apr 16, 2019 • edited

zfz1120 commented Jul 31, 2019 • edited

JorisVanEijden commented Feb 20, 2019 •

edited

JorisVanEijden commented Feb 21, 2019 •

edited

jeckel commented Mar 20, 2019 •

edited

JorisVanEijden commented Apr 16, 2019 •

edited

zfz1120 commented Jul 31, 2019 •

edited