codecept clean command does not delete directory if there is a .gitignore file in it

[Naktibalda]

PHP Warning: rmdir(/Project/tests/_output/sites/test_5617e447ddefc): Directory not empty in phar:///Project/codecept.phar/src/Codeception/Util/FileSystem.php on line 28

It happens because there is a special exception for .gitignore in

Codeception/src/Codeception/Util/FileSystem.php

Line 23 in f11bfe9

if ($basename === '.' || $basename === '..' || $basename === '.gitignore') {

It was introduced by this pull request #597

My suggestion is to check if it is _output/.gitignore specifically and delete all .gitignore files in subdirs.

[eXorus]

We still have the issue it's pretty easy to replace:

            if ($basename === '.' || $basename === '..' || $basename === '.gitignore') {
                continue;
            }

by

            if ($basename === '.' || $basename === '..') {
                continue;
            }
            if ($basename === '.gitignore' && $path->getPathInfo()->getBasename() === Configuration::outputDir()) {;
                continue;
            }

But it doesn't look good because we are in Util\FileSystem.php.

Any others idea?
If I have a folder within _output/myFolder/.gitignore, I guess we don't want to clean it.

[Naktibalda]

I have almost opposite issue now - I don't like that clean command deletes .gitkeep files in output directories, so I will add another exception for .gitkeep files.

[Naktibalda]

I raised PR to keep .gitkeep files: #6118

[eXorus]

Great so we can close this issue, it's not relevant anymore, what do you think?

[Naktibalda]

I don't remember why it was an issue to me anymore.