Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it easier to maintain this repo #24

Open
SpaceK33z opened this issue Aug 27, 2017 · 2 comments
Open

Make it easier to maintain this repo #24

SpaceK33z opened this issue Aug 27, 2017 · 2 comments

Comments

@SpaceK33z
Copy link

Currently this is a complete fork of create-react-app. I don't have the time / mood to cherry pick commits from upstream anymore, and also create-react-app (CRA) has fixed a lot of the (minor) issues I had.

I updated the README with all changes I made compared to CRA, which is still a lot. However it is probably possible to do this another way (not forking everything).

One option is React App Rewired, which makes it easy to customize create-react-app by adding a config file in your project. I don't want to repeat this file in every project though, so I'd need to research how to implement this in create-react-cy-app.

Another option is to start over from scratch, but this time only fork the react-scripts + babel preset part. A lot of the changes required in react-scripts can be done via environment variables now, so if we can separate these env variables we have to make minimal changes to the code so pulling from upstream would succeed most of the time.

@SpaceK33z
Copy link
Author

SpaceK33z commented Aug 27, 2017

Note that as a result of this, we'll get an even more awesome error overlay in the browser (since CRA improved it a lot meanwhile)

SpaceK33z added a commit that referenced this issue Sep 3, 2017
@SpaceK33z
Copy link
Author

SpaceK33z commented Sep 3, 2017

Allright let's do it.

  • Update react-cy-scripts to latest master
  • Fix eslint config for this repository
  • Re-apply changes react-cy-scripts, but better if possible;
    • Try to use NODE_PATH env instead of custom hack for src/ module resolving
    • Try out eslint-loader, maybe we should use it after all
    • Disable source maps via env variable instead of hack
    • Remove css autoprefixer
    • Use cache-loader for babel
    • Support PUBLIC_URL env in dev
    • Use babel-minify
    • Add basic Electron compat
    • Add CY_ENV_FILE support
    • Change frontend env variable prefix to CY_FRONTEND_*
    • Update template to react-cy-scripts
  • Publish 1.0.0 version
  • Simplify README

Bonus points:

  • Fix kitchensink tests
  • Enable Travis again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant