Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate build issues. #132

Closed
JordanMajd opened this issue Aug 12, 2017 · 4 comments
Closed

Investigate build issues. #132

JordanMajd opened this issue Aug 12, 2017 · 4 comments

Comments

@JordanMajd
Copy link
Contributor

Builds worked fine up until the merge of last week's minutes. We reverted to the last built commit and the repository still won't build.

@abettermap
Copy link
Contributor

The important part of GH's response to David's support request:

Here's the full error we're seeing on our side:

Liquid Exception: no implicit conversion of Integer into String in /_layouts/default.html
            Fatal: TypeError
                   no implicit conversion of Integer into String

It looks like the cause of this is a bug in Jekyll, the fix for which is quite new, and has yet to be incorporated into GitHub Pages:

jekyll/jekyll#6281

While we're working on fixing that, you should be able to resolve this error by changing the value of title: in your 404.html file:

https://github.com/CodeForFoco/codeforfoco.github.io/blob/master/404.html#L3

Can you try updating that to be a string, such as "404" instead of 404?

abettermap added a commit that referenced this issue Aug 12, 2017
Attempt to fix recent build problems. See #132.
@abettermap
Copy link
Contributor

I made the change. I'll leave this open for a sec until we know if build worked.

@abettermap
Copy link
Contributor

Happy green checkmark so i'm calling it good:

image

@abettermap
Copy link
Contributor

Ok did some minor triage and pushed things up. I think we have all the commits we need again but i'll hang on to my backup branch for a bit. Build succeeded after push, but holler if any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants