Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

supporting file type from sonatype nexus query urls #101

Closed
wants to merge 17 commits into from

Conversation

guyyosan
Copy link

@guyyosan guyyosan commented Jun 2, 2020

sonatype nexus sometimes uses urls with query params.

attempt to fix: #100

tested locally with sonatype nexus, it works

@dnkoutso
Copy link
Contributor

dnkoutso commented Jun 2, 2020

Can you please add a test?

@guyyosan
Copy link
Author

guyyosan commented Jun 2, 2020

@dnkoutso I'm a novice ruby dev :)
can you please refer me to this method's test: type_with_url?

@guyyosan
Copy link
Author

guyyosan commented Jun 2, 2020

@dnkoutso
Copy link
Contributor

dnkoutso commented Jun 2, 2020

Yes add one in remote_file_spec.rb.

Run it as bundle exec bacon /path/to/remote_file_spec.rb

@guyyosan
Copy link
Author

guyyosan commented Jun 4, 2020

@dnkoutso it's working ok now. build is passing on 2/4 machines. the other 2 machines has issues with gem installations not related to my fix.

@seanreinhardtapps
Copy link
Contributor

The failed tests are an issue with RVM with certain Ruby versions on Travis CI VMs. See #97

@guyyosan
Copy link
Author

guyyosan commented Jun 8, 2020

@seanreinhardtapps @dnkoutso is there a way to rerun ci now that #97 is merged?
I mean, without adding a new commit

@@ -58,6 +58,28 @@ def should_flatten?

def type_with_url(url)
case URI.parse(url).path
when /\.zip$/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this get pulled out into a separate function so the case logic isn't duplicated in type_with_url_query? maybe type_with_extension and then call that here and in type_with_url_query

@amorde
Copy link
Member

amorde commented Jul 7, 2020

LGTM with 1 minor change

@guyyosan
Copy link
Author

@amorde updated

@guyyosan
Copy link
Author

@amorde Hi Eric,
last build is failing for one machine.. doesn't look code related:

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@guyyosan
Copy link
Author

@dnkoutso can you please check this, I really need a proxy working asap and this is a blocker.
The build is actually succeeds on all machines but 1 and I don't understand the error, it's like output is missing

@guyyosan guyyosan requested a review from amorde December 15, 2020 17:50
@guyyosan guyyosan closed this Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error downloading pod using nexus proxy with cdn remote
4 participants