Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pod lib lint cause incompatible encoding regexp match for non-ascii pod name #9765

Closed
1 task done
banjun opened this issue May 5, 2020 · 4 comments · Fixed by #9776
Closed
1 task done

pod lib lint cause incompatible encoding regexp match for non-ascii pod name #9765

banjun opened this issue May 5, 2020 · 4 comments · Fixed by #9776
Milestone

Comments

@banjun
Copy link
Contributor

banjun commented May 5, 2020

Report

What did you do?

Run git clone https://github.com/banjun/ikemen and cd ikemen
Run pod lib lint

What did you expect to happen?

The lint pass without errors.

What happened instead?

 -> ※ikemen (0.6.0)
    - ERROR | [iOS] unknown: Encountered an unknown error (incompatible encoding regexp match (UTF-8 regexp with ASCII-8BIT string)) during validation.

Note that ※ikemen has a non-ascii character in its pod name.

CocoaPods Environment

Stack

   CocoaPods : 1.9.1
        Ruby : ruby 2.6.3p62 (2019-04-16 revision 67580) [universal.x86_64-darwin19]
    RubyGems : 3.0.3
        Host : Mac OS X 10.15.4 (19E287)
       Xcode : 11.4 (11E146)
         Git : git version 2.25.0
Ruby lib dir : /System/Library/Frameworks/Ruby.framework/Versions/2.6/usr/lib
Repositories : master - git - https://github.com/CocoaPods/Specs.git @ 0a4408de50e224aa6f8f5897d77a2a794afae854

               trunk - CDN - https://cdn.cocoapods.org/

Installation Source

Executable Path: /usr/local/bin/pod

Plugins

claide-plugins        : 0.9.2
cocoapods-app_group   : 0.4.1
cocoapods-deintegrate : 1.0.4
cocoapods-plugins     : 1.0.0
cocoapods-search      : 1.0.0
cocoapods-stats       : 1.1.0
cocoapods-trunk       : 1.5.0
cocoapods-try         : 1.2.0

Project that demonstrates the issue

https://github.com/banjun/ikemen

The pod has been validated for years (2015-).

Possible Fix

This change fixes the problem

banjun@def8d76

Other Configurations

I have tried to reproduce in other environments. It might be caused by Catalina or Catalina system ruby...? 🤔

Configuration Result Screenshot
Github Actions on macOS-latest (log) ❌ NG image-2
bitrise on Catalina stack (log) ❌ NG image-4
bitrise on Mojave stack (log) ✅ OK image-3
@dnkoutso
Copy link
Contributor

dnkoutso commented May 5, 2020

Its probably because of the character.

@banjun
Copy link
Contributor Author

banjun commented May 5, 2020

@dnkoutso yes it makes sense but non-ascii names including the character have been valid and cocoapods/specs already have such names.

@dnkoutso dnkoutso added this to the 1.10.0 milestone May 5, 2020
@dnkoutso
Copy link
Contributor

dnkoutso commented May 6, 2020

Can you please make a PR and add a test to fix this?

@banjun
Copy link
Contributor Author

banjun commented May 6, 2020

@dnkoutso Yes, I will do that 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants