Add Vendored XCFramework example to CI example projects #9576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amorde
commented
Mar 1, 2020
| @@ -295,6 +295,8 @@ begin | |||
|
|
|||
| project = Xcodeproj::Project.open(project_path) | |||
| target = project.targets.first | |||
| scheme_target = project.targets.find { |t| t.name == scheme_name } | |||
| target = scheme_target unless scheme_target.nil? | |||
There was a problem hiding this comment.
we were always using the first target to determine the platform, which doesn't work for projects that have multiple targets with different platforms
amorde
force-pushed
the
amorde/xcframework-example
branch
from
083b051
to
bfcf273
Compare
dnkoutso
approved these changes
Mar 1, 2020
|
Gonna clean up a few files before merging |
amorde
force-pushed
the
amorde/xcframework-example
branch
from
bfcf273
to
d8b384c
Compare
amorde
force-pushed
the
amorde/xcframework-example
branch
from
d8b384c
to
8e32d5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project won't build successfully until #9575 and #9574 are merged.
Also updates the examples to use Xcode 11.3.1