[Podspec] Explicit setting of 'CFBundleIdentifier' in s.info_plist causes a warning

[giofid]

As discussed here, when in the .podspec file we explicitly set the bundle identifier in this way

# in .podspec
s.info_plist = {
  'CFBundleIdentifier' => 'com.myorg.mylib'
}

XCode 11 gives a warning

warning: User-supplied CFBundleIdentifier value 'com.myorg.mylib' in the Info.plist must be the same as the PRODUCT_BUNDLE_IDENTIFIER build setting value 'org.cocoapods.mylib'

[dnkoutso]

Probably a minor bug yes, care to make a PR?

[amorde]

For anyone interested in contributing, this is currently set here:

CocoaPods/lib/cocoapods/target/build_settings.rb

Line 901 in a1c94aa

'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}'

This could potentially be moved to somewhere a bit higher level such as here:

CocoaPods/lib/cocoapods/installer/xcode/pods_project_generator/pod_target_installer.rb

Lines 199 to 220 in a1c94aa

	def custom_build_settings
	settings = super
	unless target.build_as_framework?
	settings['PRIVATE_HEADERS_FOLDER_PATH'] = ''
	settings['PUBLIC_HEADERS_FOLDER_PATH'] = ''
	end
	settings['PRODUCT_NAME'] = target.product_basename
	settings['PRODUCT_MODULE_NAME'] = target.product_module_name
	settings['CODE_SIGN_IDENTITY[sdk=appletvos*]'] = ''
	settings['CODE_SIGN_IDENTITY[sdk=iphoneos*]'] = ''
	settings['CODE_SIGN_IDENTITY[sdk=watchos*]'] = ''
	settings['SWIFT_ACTIVE_COMPILATION_CONDITIONS'] = '$(inherited) '
	if target.swift_version
	settings['SWIFT_VERSION'] = target.swift_version
	end
	settings
	end