Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated Pods-PROJECTNAME-resources.sh fails when project is loaded from symbolic link directory #9423

Closed
1 task done
dwsjoquist opened this issue Dec 19, 2019 · 3 comments
Labels
d1:easy An easy ticket that is a good start for first-time contributors t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Milestone

Comments

@dwsjoquist
Copy link

dwsjoquist commented Dec 19, 2019

Report

What did you do?

Built project that was loaded from a symbolic link on mac os.

What did you expect to happen?

Project should build successfully.

What happened instead?

It fails on these lines:

# Find all other xcassets (this unfortunately includes those of path pods and other targets).
  OTHER_XCASSETS=$(find "$PWD" -iname "*.xcassets" -type d)

The problem as I understand it is that the find behaves differently with symbolic links. If I load the project from the full, normal path, it builds fine.

The $PWD value is something like this: /d/mydir and if I temporarily change the script to this, it works fine:

OTHER_XCASSETS=$(find -L "$PWD" -iname "*.xcassets" -type d)
@dnkoutso
Copy link
Contributor

yes that could be an improvement by passing -L.

@dnkoutso dnkoutso added this to the 1.9.0 milestone Dec 19, 2019
@dnkoutso dnkoutso added d1:easy An easy ticket that is a good start for first-time contributors t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome! labels Dec 19, 2019
@dwsjoquist
Copy link
Author

Thank you :)

@dnkoutso dnkoutso closed this as completed Jan 7, 2020
@dnkoutso
Copy link
Contributor

dnkoutso commented Jan 7, 2020

Will ship with 1.9.0.beta.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
d1:easy An easy ticket that is a good start for first-time contributors t2:defect These are known bugs. The issue should also contain steps to reproduce. PRs welcome!
Projects
None yet
Development

No branches or pull requests

2 participants