New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to build with Xcode 12.1 #10815
Conversation
1f152df
to
649884e
Compare
@@ -335,6 +335,7 @@ | |||
baseConfigurationReference = A8A706EB2A5031760E4C935B /* Pods-Vendored Framework Example.debug.xcconfig */; | |||
buildSettings = { | |||
ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon; | |||
EXCLUDED_ARCHS = arm64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this example we consume a vendored framework that does not ship this architecture. Excluding this arch is fine.
Here's an example of your CHANGELOG entry: * Update examples to build with Xcode 12.1
[dnkoutso](https://github.com/dnkoutso)
[#issue_number](https://github.com/CocoaPods/CocoaPods/issues/issue_number) note: There are two invisible spaces after the entry's text. Generated by 🚫 Danger |
Apple clang version 12.0.0 (clang-1200.0.32.21) | ||
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS14.1.sdk | ||
iPhoneOS14.1.sdk | ||
/Users/dimitris/Library/Developer/Xcode/DerivedData/CoconutLib-emvxikeulksgclhknusminvzkhbs/Build/Intermediates.noindex/ArchiveIntermediates/CoconutLib-iOS/IntermediateBuildFilesPath/CoconutLib.build/Release-iphoneos/CoconutLib-iOS.build/DerivedSources/CoconutLib_vers.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the previous bcsymbolmaps had absolute paths as well.
@@ -0,0 +1,13 @@ | |||
BCSymbolMap Version: 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should these files be gitignored?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like they were not previously. What you see here is additions of new of these files due to new architectures since I rebuilt this framework using Xcode 12.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I think we use these to verify that the apps build with bitcode enabled but don't remember the specifics
I had to rebuild the
CoconutLib.xcframework
, dynamic, static and static library using Xcode 12.1.