Fix missing -ObjC for xcframeworks - take 2 #10460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
commented
Feb 24, 2021
paulb777
changed the title
paulb777
changed the title
This was referenced Feb 25, 2021
dnkoutso
reviewed
Feb 25, 2021
| # that come shipped with the Pod. | ||
| # | ||
| def vendored_static_xcframeworks | ||
| vendored_xcframeworks.select do |path| |
There was a problem hiding this comment.
do these need to be compact?
There was a problem hiding this comment.
I guess not it seems it only selects the ones that are static frameworks?
There was a problem hiding this comment.
I think since select just needs a boolean we don't need to return the path
select do |path|
Xcode::XCFramework.new(path).build_type == BuildType.static_framework
end
There was a problem hiding this comment.
Confirmed. Thanks @amorde !
dnkoutso
approved these changes
Feb 25, 2021
amorde
approved these changes
Mar 9, 2021
|
@paulb777 whats left here? is it just landing integration specs, merging this and publishing 1.10.2? |
|
@dnkoutso Yes. It should be ready to go. |
|
OK merged integration specs! |
|
Integration tests updated in CocoaPods/cocoapods-integration-specs#313 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10459 - a better file_accessor solution that undoes the build_settings.rb changes from #10234
Integration test companion is CocoaPods/cocoapods-integration-specs#312