From f1a4a8b8aeb1d3591db27021a9236ce658903d11 Mon Sep 17 00:00:00 2001 From: Igor Makarov Date: Tue, 2 Mar 2021 19:41:18 +0200 Subject: [PATCH] disable `Metrics/BlockLength` --- .rubocop_cocoapods.yml | 5 +++++ .rubocop_todo.yml | 5 ----- spec/unit/installer/analyzer_spec.rb | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.rubocop_cocoapods.yml b/.rubocop_cocoapods.yml index 65639bfd83..67a2e67374 100644 --- a/.rubocop_cocoapods.yml +++ b/.rubocop_cocoapods.yml @@ -57,6 +57,11 @@ GuardClause: Next: Enabled: false +# Arbitrary max lengths for classes simply do not work and enabling this will +# lead to a never ending stream of annoyance and changes. +Metrics/BlockLength: + Enabled: false + # Arbitrary max lengths for classes simply do not work and enabling this will # lead to a never ending stream of annoyance and changes. Metrics/ClassLength: diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 5e424b137c..a4287555f9 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -234,11 +234,6 @@ Lint/UriRegexp: Lint/UselessAccessModifier: Enabled: false -# Offense count: 373 -# Configuration parameters: CountComments, ExcludedMethods. -Metrics/BlockLength: - Max: 1476 - # Offense count: 7099 # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns. # URISchemes: http, https diff --git a/spec/unit/installer/analyzer_spec.rb b/spec/unit/installer/analyzer_spec.rb index eaa4b55f0f..a1ea755d21 100644 --- a/spec/unit/installer/analyzer_spec.rb +++ b/spec/unit/installer/analyzer_spec.rb @@ -1,8 +1,8 @@ require File.expand_path('../../../spec_helper', __FILE__) module Pod - describe Installer::Analyzer do # rubocop:disable Metrics/BlockLength - describe 'Analysis' do # rubocop:disable Metrics/BlockLength + describe Installer::Analyzer do + describe 'Analysis' do before do repos = [Source.new(fixture('spec-repos/test_repo')), TrunkSource.new(fixture('spec-repos/trunk'))] aggregate = Pod::Source::Aggregate.new(repos)