validator_spec.rb

require File.expand_path('../../spec_helper', __FILE__)
require 'webmock'

module Pod
  describe Validator do
    before do
      # get these in before mock activates
      podspec_path
      podspec_path('RestKit', '0.22.0')
      WebMock.enable!
      WebMock.disable_net_connect!
    end

    before do
      Validator.any_instance.stubs(:xcodebuild).returns('')
      Validator.any_instance.stubs(:xcodebuild_available?).returns(true)
    end

    # @return [void]
    #
    def write_podspec(text, name = 'JSONKit.podspec.json')
      file = temporary_directory + name
      File.open(file, 'w') { |f| f.write(text) }
      file
    end

    # @return [String]
    #
    def stub_podspec(pattern = nil, replacement = nil)
      spec = podspec_path.read
      spec.gsub!(/.*license.*$/, '"license": "Public Domain",')
      spec.gsub!(%r{https://github\.com/johnezang/JSONKit\.git}, fixture('integration/JSONKit').to_s)
      spec.gsub!(pattern, replacement) if pattern && replacement
      spec
    end

    # @return [Pathname]
    #
    def podspec_path(name = 'JSONKit', version = '1.4', source = nil)
      source = Config.instance.sources_manager.master.first if source.nil?
      source.specification_path(name, version)
    end

    def stub_downloader_cache_rsync
      Downloader::Cache.any_instance.expects(:rsync_contents).with { |_, destination| FileUtils.mkdir_p(destination) }
    end

    #-------------------------------------------------------------------------#

    describe 'Quick mode' do
      it 'validates a correct podspec' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.quick = true
        validator.validate
        validator.results.should == []
        validator.validated?.should.be.true
      end

      it 'lints the podspec during validation' do
        podspec = stub_podspec(/.*name.*/, '"name": "TEST",')
        file = write_podspec(podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.quick = true
        validator.validate
        validator.results.map(&:to_s).first.should.match /should match the name/
        validator.validated?.should.be.false
      end

      it 'respects quick mode' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.quick = true
        validator.expects(:perform_extensive_analysis).never
        validator.validate
      end

      it 'respects the allow warnings option' do
        podspec = stub_podspec(/.*summary.*/, '"summary": "A short description of",')
        file = write_podspec(podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.quick = true
        validator.allow_warnings = true
        validator.validate
        validator.results.map(&:to_s).first.should.match /summary.*meaningful/
        validator.validated?.should.be.true
      end

      it 'handles symlinks' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.quick = true
        validator.stubs(:validate_url)
        validator.validate
        validator.validated?.should.be.true
      end

      describe '#only_subspec' do
        before do
          test_repo_source = Config.instance.sources_manager.source_with_name_or_url('test_repo')
          podspec = podspec_path('RestKit', '0.22.0', test_repo_source)
          @validator = Validator.new(podspec, config.sources_manager.master.map(&:url))
          @validator.quick = true
        end

        it 'handles a relative subspec name' do
          @validator.only_subspec = 'CoreData'
          @validator.validate
          @validator.send(:subspec_name).should == 'RestKit/CoreData'
        end

        it 'handles an absolute subspec name' do
          @validator.only_subspec = 'RestKit/CoreData'
          @validator.validate
          @validator.send(:subspec_name).should == 'RestKit/CoreData'
        end

        it 'handles a relative subspec name which starts with the pod name' do
          @validator.only_subspec = 'RestKitSubspec'
          @validator.validate
          @validator.send(:subspec_name).should == 'RestKit/RestKitSubspec'
        end

        it 'handles an absolute subspec name which starts with the pod name' do
          @validator.only_subspec = 'RestKit/RestKitSubspec'
          @validator.validate
          @validator.send(:subspec_name).should == 'RestKit/RestKitSubspec'
        end

        it 'handles a missing subspec name' do
          @validator.only_subspec = 'RestKit/Missing'
          should.raise(Informative) { @validator.validate }.message.
            should.include 'Unable to find a specification named `RestKit/Missing`'

          @validator.only_subspec = 'Missing'
          should.raise(Informative) { @validator.validate }.message.
            should.include 'Unable to find a specification named `RestKit/Missing`'
        end
      end
    end

    #-------------------------------------------------------------------------#

    describe 'Extensive analysis' do
      describe 'URL validation' do
        before do
          @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
          @validator.stubs(:download_pod)
          @validator.stubs(:check_file_patterns)
          @validator.stubs(:install_pod)
          @validator.stubs(:add_app_project_import)
          @validator.stubs(:build_pod)
          @validator.stubs(:tear_down_validation_environment)
          @validator.stubs(:perform_linting)
          @validator.stubs(:validate_homepage)
          @validator.stubs(:validate_screenshots)
          @validator.stubs(:validate_social_media_url)
          @validator.stubs(:validate_documentation_url)
          @validator.stubs(:validate_source_url)
          @validator.stubs(:perform_extensive_subspec_analysis)
          Specification.any_instance.stubs(:available_platforms).returns([])

          WebMock::API.stub_request(:head, /not-found/).to_return(:status => 404)
          WebMock::API.stub_request(:get, /not-found/).to_return(:status => 404)
        end

        describe 'Homepage validation' do
          before do
            @validator.unstub(:validate_homepage)
          end

          it 'checks if the homepage is valid' do
            Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/not-found/')
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /The URL (.*) is not reachable/
          end

          it 'indicates if it was not able to validate the homepage' do
            WebMock::API.stub_request(:head, 'banana-corp.local').to_raise(SocketError)
            Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/')
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /There was a problem validating the URL/
          end

          it 'does not fail if the homepage redirects' do
            WebMock::API.stub_request(:head, /redirect/).to_return(
              :status => 301, :headers => { 'Location' => 'http://banana-corp.local/found/' })
            WebMock::API.stub_request(:head, /found/).to_return(:status => 200)
            Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/redirect/')
            @validator.validate
            @validator.results.should.be.empty
          end

          it 'does not fail if the homepage does not support HEAD' do
            WebMock::API.stub_request(:head, /page/).to_return(:status => 405)
            WebMock::API.stub_request(:get, /page/).to_return(:status => 200)
            Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/page/')
            @validator.validate
            @validator.results.should.be.empty
          end

          it 'does not fail if the homepage errors on HEAD' do
            WebMock::API.stub_request(:head, /page/).to_return(:status => 500)
            WebMock::API.stub_request(:get, /page/).to_return(:status => 200)
            Specification.any_instance.stubs(:homepage).returns('http://banana-corp.local/page/')
            @validator.validate
            @validator.results.should.be.empty
          end

          it 'does not follow redirects infinitely' do
            WebMock::API.stub_request(:head, /redirect/).to_return(
              :status => 301,
              :headers => { 'Location' => 'http://banana-corp.local/redirect/' })
            Specification.any_instance.stubs(:homepage).returns(
              'http://banana-corp.local/redirect/')
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /The URL \(.*\) is not reachable/
          end

          it 'supports relative redirects' do
            WebMock::API.stub_request(:head, /redirect/).to_return(
              :status => 302,
              :headers => { 'Location' => '/foo' })
            WebMock::API.stub_request(:head, /foo/).to_return(
              :status => 200)
            Specification.any_instance.stubs(:homepage).returns(
              'http://banana-corp.local/redirect')
            @validator.validate
            @validator.results.should.be.empty
          end
        end

        describe 'Screenshot validation' do
          before do
            @validator.unstub(:validate_screenshots)
            WebMock::API.
              stub_request(:head, 'banana-corp.local/valid-image.png').
              to_return(
                :status => 200,
                :headers => { 'Content-Type' => 'image/png' },
              )
          end

          it 'checks if the screenshots are valid' do
            Specification.any_instance.stubs(:screenshots).
              returns(['http://banana-corp.local/valid-image.png'])
            @validator.validate
            @validator.results.should.be.empty?
          end

          it 'should fail if any of the screenshots URLS do not return an image' do
            WebMock::API.stub_request(:head, 'banana-corp.local/').to_return(:status => 200)
            Specification.any_instance.stubs(:screenshots).returns(['http://banana-corp.local/valid-image.png', 'http://banana-corp.local/'])
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /The screenshot .* is not a valid image/
          end
        end

        describe 'social media URL validation' do
          before do
            @validator.unstub(:validate_social_media_url)
          end

          it 'checks if the social media URL is valid' do
            Specification.any_instance.stubs(:social_media_url).returns('http://banana-corp.local/')
            WebMock::API.stub_request(:head, /banana-corp.local/).to_return(:status => 200)
            @validator.validate
            @validator.results.should.be.empty?
          end

          it "should fail validation if it wasn't able to validate the URL" do
            Specification.any_instance.stubs(:social_media_url).returns('http://banana-corp.local/not-found/')
            WebMock::API.stub_request(:head, /banana-corp.local/).to_return(:status => 404)
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /The URL \(.*\) is not reachable/
          end
        end

        describe 'source URL validation' do
          before do
            @validator.unstub(:validate_source_url)
          end

          it 'checks if the source URL is valid' do
            Specification.any_instance.stubs(:source).returns(:http => 'https://orta.io/package.zip')
            @validator.validate
            @validator.results.should.be.empty?
          end

          it 'should fail validation if the source URL is not HTTPS encrypted' do
            Specification.any_instance.stubs(:source).returns(:http => 'http://orta.io/package.zip')
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /use the encrypted HTTPS protocol./
          end

          it 'should not fail validation if the source URL is using file:///' do
            Specification.any_instance.stubs(:source).returns(:http => 'file:///orta.io/package.zip')
            @validator.validate
            @validator.results.should.be.empty?
          end
        end

        describe 'documentation URL validation' do
          before do
            @validator.unstub(:validate_documentation_url)
          end

          it 'checks if the documentation URL is valid' do
            Specification.any_instance.stubs(:documentation_url).returns('http://banana-corp.local/')
            WebMock::API.stub_request(:head, /banana-corp.local/).to_return(:status => 200)
            @validator.validate
            @validator.results.should.be.empty?
          end

          it "should fail validation if it wasn't able to validate the URL" do
            Specification.any_instance.stubs(:documentation_url).returns('http://banana-corp.local/not-found')
            @validator.validate
            @validator.results.map(&:to_s).first.should.match /The URL (.*) is not reachable/
          end
        end
      end

      it 'respects the no clean option when set to true' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.stubs(:validate_url)
        validator.stubs(:download_pod)
        validator.no_clean = true
        validator.expects(:clean!).never
        validator.validate
      end

      it 'respects the no clean option when set to false' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.stubs(:validate_url)
        validator.stubs(:download_pod)
        validator.no_clean = false
        validator.expects(:clean!).once
        validator.validate
      end

      describe 'Platforms' do
        it 'builds the pod per platform' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:validate_url)
          validator.expects(:install_pod).times(5)
          validator.expects(:build_pod).times(5)
          validator.expects(:add_app_project_import).times(5)
          validator.expects(:check_file_patterns).times(5)
          validator.validate
        end

        it 'builds the pod per platform specified' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios osx))
          validator.stubs(:validate_url)
          validator.expects(:install_pod).times(2)
          validator.expects(:build_pod).times(2)
          validator.expects(:add_app_project_import).times(2)
          validator.expects(:check_file_patterns).times(2)
          validator.validate
        end

        it 'builds the pod per platform specified, ignoring duplicates' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios osx macos ios))
          validator.stubs(:validate_url)
          validator.expects(:install_pod).times(2)
          validator.expects(:build_pod).times(2)
          validator.expects(:add_app_project_import).times(2)
          validator.expects(:check_file_patterns).times(2)
          validator.validate
        end

        it 'only builds the platforms specified' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios osx))
          validator.send(:platforms_to_lint, validator.spec).map(&:to_s).sort.should == %w(iOS macOS)

          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios osx watchos tvos))
          validator.send(:platforms_to_lint, validator.spec).map(&:to_s).sort.should == %w(iOS macOS tvOS watchOS)
        end

        it 'raises when given an invalid platform' do
          file = write_podspec(stub_podspec)
          should.raise(Informative) do
            Validator.new(file, config.sources_manager.master.map(&:url), %w(ios amazingos))
          end
        end

        it 'raises when given a platform not supported by the specification' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios watchos tvos))
          validator.spec.stubs(:available_platforms).returns([Platform.ios])
          should.raise(Informative) do
            validator.send(:platforms_to_lint, validator.spec)
          end
        end

        it 'includes only tests supported on the current platform' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios osx))
          validator.use_frameworks = false
          validator.instance_variable_set(:@results, [])
          subspec = Specification.new(validator.spec, 'Tests', true) do |s|
            s.platform = :ios
          end
          validator.spec.stubs(:test_specs).returns([subspec])
          validator.stubs(:validate_url)
          validator.stubs(:validate_screenshots)
          validator.stubs(:check_file_patterns)
          validator.stubs(:install_pod)
          validator.stubs(:add_app_project_import)
          validator.stubs(:test_pod)
          %i(prepare resolve_dependencies download_dependencies write_lockfiles).each do |m|
            Installer.any_instance.stubs(m)
          end
          Installer.any_instance.stubs(:aggregate_targets).returns([])
          Installer.any_instance.stubs(:pod_targets).returns([])
          validator.expects(:podfile_from_spec).with(:osx, nil, false, [], nil, nil).once.returns(stub('Podfile'))
          validator.expects(:podfile_from_spec).with(:ios, nil, false, ['JSONKit/Tests'], nil, nil).once.returns(stub('Podfile'))
          validator.validate
        end

        it 'test_pod only runs on supported platforms' do
          file = write_podspec(stub_podspec)
          validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios osx))
          validator.instance_variable_set(:@results, [])

          debug_configuration_one = stub(:build_settings => {})
          native_target_one = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_one]))
          pod_target_one = stub(:name => 'PodTarget1', :pod_name => 'JSONKit', :uses_swift? => true, :swift_version => '4.0')
          pod_target_installation_one = stub(:target => pod_target_one, :native_target_for_spec => native_target_one,
                                             :test_native_targets => [],
                                             :test_specs_by_native_target => {})
          pod_target_installation_results = { 'PodTarget1' => pod_target_installation_one }

          installer = stub(:pod_targets => [pod_target_one],
                           :target_installation_results => [pod_target_installation_results])
          validator.instance_variable_set(:@installer, installer)
          subspec = Specification.new(validator.spec, 'Tests', true) do |s|
            s.platform = :ios
          end
          validator.spec.stubs(:test_specs).returns([subspec])
          validator.stubs(:parse_xcodebuild_output)
          validator.stubs(:translate_output_to_linter_messages)

          # expect only one call to xcodebuild even though we're running test_pod for two platforms
          validator.expects(:xcodebuild).times(1)

          [:ios, :osx].each do |platform|
            consumer = validator.spec.consumer(platform)
            validator.instance_variable_set(:@consumer, consumer)
            validator.send(:test_pod)
          end
        end
      end

      it 'test_pod runs multiple test_specs' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios))
        validator.instance_variable_set(:@results, [])

        debug_configuration_one = stub(:build_settings => {})
        native_target_one = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_one]))
        pod_target_one = stub(:name => 'PodTarget1', :pod_name => 'JSONKit', :uses_swift? => true, :swift_version => '4.0')
        pod_target_installation_one = stub(:target => pod_target_one, :native_target_for_spec => native_target_one,
                                           :test_native_targets => [],
                                           :test_specs_by_native_target => {})
        pod_target_installation_results = { 'PodTarget1' => pod_target_installation_one }

        installer = stub(:pod_targets => [pod_target_one],
                         :target_installation_results => [pod_target_installation_results])
        validator.instance_variable_set(:@installer, installer)
        test_spec1 = Specification.new(validator.spec, 'Tests1', true) do |s|
          s.platform = :ios
        end
        test_spec2 = Specification.new(validator.spec, 'Tests2', true) do |s|
          s.platform = :ios
        end
        test_spec3 = Specification.new(validator.spec, 'Tests3', true) do |s|
          s.platform = :ios
        end
        validator.spec.stubs(:test_specs).returns([test_spec1, test_spec2, test_spec3])
        validator.stubs(:parse_xcodebuild_output)
        validator.stubs(:translate_output_to_linter_messages)

        # expect three calls to xcodebuild
        validator.expects(:xcodebuild).times(3)

        consumer = validator.spec.consumer(:ios)
        validator.instance_variable_set(:@consumer, consumer)
        validator.send(:test_pod)
      end

      it 'test_pod runs a single specified test_spec' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios))
        validator.instance_variable_set(:@results, [])

        debug_configuration_one = stub(:build_settings => {})
        native_target_one = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_one]))
        pod_target_one = stub(:name => 'PodTarget1', :pod_name => 'JSONKit', :uses_swift? => true, :swift_version => '4.0')
        pod_target_installation_one = stub(:target => pod_target_one, :native_target_for_spec => native_target_one,
                                           :test_native_targets => [],
                                           :test_specs_by_native_target => {})
        pod_target_installation_results = { 'PodTarget1' => pod_target_installation_one }

        installer = stub(:pod_targets => [pod_target_one],
                         :target_installation_results => [pod_target_installation_results])
        validator.instance_variable_set(:@installer, installer)
        test_spec1 = Specification.new(validator.spec, 'Tests1', true) do |s|
          s.platform = :ios
        end
        test_spec2 = Specification.new(validator.spec, 'Tests2', true) do |s|
          s.platform = :ios
        end
        test_spec3 = Specification.new(validator.spec, 'Tests3', true) do |s|
          s.platform = :ios
        end
        validator.test_specs = ['Tests2']
        validator.spec.stubs(:test_specs).returns([test_spec1, test_spec2, test_spec3])
        validator.stubs(:parse_xcodebuild_output)
        validator.stubs(:translate_output_to_linter_messages)

        # expect only one call to xcodebuild
        validator.expects(:xcodebuild).once.returns('file.m:1:1: error: Pretended!')

        consumer = validator.spec.consumer(:ios)
        validator.instance_variable_set(:@consumer, consumer)
        validator.send(:test_pod)
      end

      it '--skip-tests runs specified tests' do
        file = write_podspec(stub_podspec)
        validator = Validator.new(file, config.sources_manager.master.map(&:url), %w(ios))
        validator.instance_variable_set(:@results, [])

        debug_configuration_one = stub(:build_settings => {})
        native_target_one = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_one]))
        pod_target_one = stub(:name => 'PodTarget1', :pod_name => 'JSONKit', :uses_swift? => true, :swift_version => '4.0')
        pod_target_installation_one = stub(:target => pod_target_one, :native_target_for_spec => native_target_one,
                                           :test_native_targets => [],
                                           :test_specs_by_native_target => {})
        pod_target_installation_results = { 'PodTarget1' => pod_target_installation_one }

        installer = stub(:pod_targets => [pod_target_one],
                         :target_installation_results => [pod_target_installation_results])
        validator.instance_variable_set(:@installer, installer)
        test_spec1 = Specification.new(validator.spec, 'Tests1', true) do |s|
          s.platform = :ios
        end
        test_spec2 = Specification.new(validator.spec, 'Tests2', true) do |s|
          s.platform = :ios
        end
        test_spec3 = Specification.new(validator.spec, 'Tests3', true) do |s|
          s.platform = :ios
        end
        validator.test_specs = %w(Tests1 Tests3)
        validator.spec.stubs(:test_specs).returns([test_spec1, test_spec2, test_spec3])
        validator.stubs(:parse_xcodebuild_output)
        validator.stubs(:translate_output_to_linter_messages)

        # expect two calls to xcodebuild for two specified test_specs
        validator.expects(:xcodebuild).times(2)

        consumer = validator.spec.consumer(:ios)
        validator.instance_variable_set(:@consumer, consumer)
        validator.send(:test_pod)
      end

      it 'builds the pod only once if the first fails with fail_fast' do
        Validator.any_instance.unstub(:xcodebuild)
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        validator.fail_fast = true
        validator.expects(:xcodebuild).once.returns('file.m:1:1: error: Pretended!')
        validator.validate
        validator.result_type.should == :error
      end

      it 'uses the deployment target of the specification' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:validate_url)
        validator.stubs(:validate_screenshots)
        podfile = validator.send(:podfile_from_spec, :ios, '5.0')
        dependency = podfile.target_definitions['App'].dependencies.first
        dependency.external_source.key?(:podspec).should.be.true
      end

      it 'uses the deployment target of the current subspec' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.use_frameworks = false
        validator.instance_variable_set(:@results, [])
        validator.stubs(:validate_url)
        validator.stubs(:validate_screenshots)
        validator.stubs(:check_file_patterns)
        validator.stubs(:install_pod)
        validator.stubs(:add_app_project_import)
        %i(prepare resolve_dependencies download_dependencies write_lockfiles).each do |m|
          Installer.any_instance.stubs(m)
        end
        Installer.any_instance.stubs(:aggregate_targets).returns([])
        Installer.any_instance.stubs(:pod_targets).returns([])
        subspec = Specification.new(validator.spec, 'subspec') do |s|
          s.ios.deployment_target = '7.0'
        end
        validator.spec.stubs(:subspecs).returns([subspec])
        validator.expects(:podfile_from_spec).with(:osx, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        validator.expects(:podfile_from_spec).with(:ios, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        validator.expects(:podfile_from_spec).with(:ios, '7.0', false, [], nil, nil).once.returns(stub('Podfile'))
        validator.expects(:podfile_from_spec).with(:tvos, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        validator.expects(:podfile_from_spec).with(:visionos, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        validator.expects(:podfile_from_spec).with(:watchos, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        validator.send(:perform_extensive_analysis, validator.spec)

        validator.results_message.strip.should.be.empty
      end

      it 'uses the deployment target of the current test spec' do
        require 'fourflusher'
        Validator.any_instance.unstub(:xcodebuild)
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.use_frameworks = true
        validator.instance_variable_set(:@results, [])
        validator.stubs(:validate_url)
        validator.stubs(:validate_screenshots)
        validator.stubs(:check_file_patterns)
        validator.stubs(:install_pod)
        validator.stubs(:add_app_project_import)
        %i(prepare resolve_dependencies download_dependencies write_lockfiles).each do |m|
          Installer.any_instance.stubs(m)
        end
        Installer.any_instance.stubs(:aggregate_targets).returns([])
        Installer.any_instance.stubs(:pod_targets).returns([])
        validator.spec.ios.deployment_target = '8.0'
        test_spec = Specification.new(validator.spec, 'testspec', true) do |s|
          s.ios.deployment_target = '9.0'
        end
        validator.spec.stubs(:subspecs).returns([test_spec])
        pod_target = stub('JSONKit-PodTarget')
        pod_target.stubs(:name).returns('JSONKit')
        validator.stubs(:validation_pod_target).returns(pod_target)
        target_installation_result = stub('JSONKitTargetInstallationResult')
        target_installation_result.stubs(:native_target_for_spec).with(test_spec).returns('Testspec-Target')
        Installer.any_instance.stubs(:target_installation_results).returns([{ 'JSONKit' => target_installation_result }])
        Fourflusher::SimControl.any_instance.expects(:destination).with(:oldest, 'iOS', '8.0').returns(['-destination', 'id=XXX'])
        Fourflusher::SimControl.any_instance.expects(:destination).with(:oldest, 'iOS', '9.0').returns(['-destination', 'id=XXX'])

        validator.validate
      end

      describe '#podfile_from_spec' do
        before do
          @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
          @validator.stubs(:validate_url)
        end

        it 'configures the deployment target' do
          podfile = @validator.send(:podfile_from_spec, :ios, '5.0')
          target_definition = podfile.target_definitions['App']
          platform = target_definition.platform
          platform.symbolic_name.should == :ios
          platform.deployment_target.to_s.should == '5.0'
        end

        it 'includes the use_frameworks! directive' do
          podfile = @validator.send(:podfile_from_spec, :ios, '5.0', true)
          target_definition = podfile.target_definitions['App']
          target_definition.uses_frameworks?.should == true
        end

        it 'includes the use_frameworks!(false) directive' do
          podfile = @validator.send(:podfile_from_spec, :ios, '5.0', false)
          target_definition = podfile.target_definitions['App']
          # rubocop:disable Style/DoubleNegation
          (!!target_definition.uses_frameworks?).should == false
          # rubocop:enable Style/DoubleNegation
        end

        it 'includes the use_modular_headers! directive' do
          podfile = @validator.send(:podfile_from_spec, :ios, '5.0', false, [], true)
          target_definition = podfile.target_definitions['App']
          target_definition.use_modular_headers_hash['all'].should.be.true
          target_definition.uses_frameworks?.should == false
        end

        it 'validates with --use-static-frameworks' do
          podfile = @validator.send(:podfile_from_spec, :ios, '5.0', false, [], false, true)
          target_definition = podfile.target_definitions['App']
          target_definition.uses_frameworks?.should == true
          target_definition.use_frameworks!.should == { :linkage => :dynamic, :packaging => :framework }
        end

        it 'inhibits warnings for all pods except the one being validated' do
          podfile = @validator.send(:podfile_from_spec, :ios, '5.0')
          target_definition = podfile.target_definitions['App']
          target_definition.should.not.inhibits_warnings_for_pod?('JSONKit')
          target_definition.should.inhibits_warnings_for_pod?('NotJSONKit')
        end
      end

      it 'empties sources when no dependencies' do
        sources = ['trunk', Pod::TrunkSource::TRUNK_REPO_URL]
        Command::Repo::Add.any_instance.stubs(:run)
        validator = Validator.new(podspec_path, sources)
        validator.stubs(:validate_url)
        podfile = validator.send(:podfile_from_spec, :ios, '5.0')
        podfile.sources.should == %w()
      end

      it 'respects the source_urls parameter when there are dependencies' do
        podspec = stub_podspec(/.*name.*/, '"name": "SBJson",').gsub(/.*version.*/, '"version": "3.2",')
        file = write_podspec(podspec, 'SBJson.podspec.json')
        spec = Specification.from_file(file)
        set = mock
        set.stubs(:all_specifications).returns([spec])
        Source::Aggregate.any_instance.stubs(:search).with(Dependency.new('SBJson', '~> 3.2')).returns(set)

        podspec = stub_podspec(/.*name.*/, '"name": "ZKit",')
        podspec.gsub!(/.*requires_arc.*/, '"dependencies": { "SBJson": [ "~> 3.2" ] }, "requires_arc": false')
        file = write_podspec(podspec, 'ZKit.podspec.json')

        spec = Specification.from_file(file)

        sources = ['trunk', Pod::TrunkSource::TRUNK_REPO_URL]
        Command::Repo::Add.any_instance.stubs(:run)
        validator = Validator.new(spec, sources)
        validator.stubs(:validate_url)
        podfile = validator.send(:podfile_from_spec, :ios, '5.0')
        podfile.sources.should == [Pod::TrunkSource::TRUNK_REPO_URL]
      end

      it 'respects the source_urls parameter when there are dependencies within subspecs' do
        podspec = stub_podspec(/.*name.*/, '"name": "SBJson",').gsub(/.*version.*/, '"version": "3.2",')
        file = write_podspec(podspec, 'SBJson.podspec.json')
        spec = Specification.from_file(file)
        set = mock
        set.stubs(:all_specifications).returns([spec])
        Source::Aggregate.any_instance.stubs(:search).with(Dependency.new('SBJson', '~> 3.2')).returns(set)

        podspec = stub_podspec(/.*name.*/, '"name": "ZKit",')
        podspec.gsub!(/.*requires_arc.*/, '"subspecs": [ { "name":"SubSpecA", "dependencies": { "SBJson": [ "~> 3.2" ] } } ], "requires_arc": false')
        file = write_podspec(podspec, 'ZKit.podspec.json')

        spec = Specification.from_file(file)

        sources = ['trunk', Pod::TrunkSource::TRUNK_REPO_URL]
        Command::Repo::Add.any_instance.stubs(:run)
        validator = Validator.new(spec, sources)
        validator.stubs(:validate_url)
        podfile = validator.send(:podfile_from_spec, :ios, '5.0')
        podfile.sources.should == [Pod::TrunkSource::TRUNK_REPO_URL]
      end

      it 'avoids creation of sources when no dependencies' do
        sources = ['trunk', Pod::TrunkSource::TRUNK_REPO_URL]
        config.sources_manager.expects(:find_or_create_source_with_url).never
        Command::Repo::Add.any_instance.stubs(:run)
        validator = Validator.new(podspec_path, sources)
        validator.stubs(:validate_url)
        validator.validate
      end

      it 'uses xcodebuild to generate warnings' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:xcodebuild).returns("file.m:1:1: warning: 'dataFromPropertyList:format:errorDescription:' is deprecated: first deprecated in iOS 8.0 - Use dataWithPropertyList:format:options:error: instead. [-Wdeprecated-declarations]")
        validator.stubs(:validate_url)
        validator.validate
        first = validator.results.map(&:to_s).first
        first.should.include '[xcodebuild]'
        validator.result_type.should == :warning
      end

      it 'uses xcodebuild to generate notes' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:xcodebuild).returns("file.m:1:1: note: 'dataFromPropertyList:format:errorDescription:' has been explicitly marked deprecated here")
        validator.stubs(:validate_url)
        validator.validate
        first = validator.results.map(&:to_s).first
        first.should.include '[xcodebuild]'
        validator.result_type.should == :note
      end

      it 'checks if xcodebuild returns a successful status code' do
        require 'fourflusher'
        Fourflusher::SimControl.any_instance.stubs(:destination).returns(['-destination', 'id=XXX'])
        Validator.any_instance.unstub(:xcodebuild)
        stub_downloader_cache_rsync
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        git = Executable.which(:git)
        Executable.stubs(:which).with('git').returns(git)
        Executable.stubs(:which).with(:xcrun)
        validator.stubs(:_xcodebuild).raises(Informative)
        validator.validate
        first = validator.results.map(&:to_s).first
        first.should.include '[xcodebuild] Returned an unsuccessful exit code'
        validator.result_type.should == :error
      end

      it 'runs xcodebuild with correct arguments when skipping import validation' do
        require 'fourflusher'
        Fourflusher::SimControl.any_instance.stubs(:destination).returns(['-destination', 'id=XXX'])
        Validator.any_instance.unstub(:xcodebuild)
        stub_downloader_cache_rsync
        PodTarget.any_instance.stubs(:should_build?).returns(true)
        Installer::Xcode::PodsProjectGenerator::PodTargetInstaller.any_instance.stubs(:validate_targets_contain_sources) # since we skip downloading
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        validator.skip_import_validation = true
        git = Executable.which(:git)
        Executable.stubs(:which).with('git').returns(git)
        Executable.stubs(:capture_command).with('git', ['config', '--get', 'remote.origin.url'], :capture => :out).returns(['https://github.com/CocoaPods/Specs.git'])
        Executable.stubs(:which).with(:xcrun)
        Executable.expects(:execute_command).with { |executable, command, _| executable == 'git' && command.first == 'clone' }.once
        # Command should include the pod target 'JSONKit' instead of the 'App' target.
        command = ['clean', 'build', '-workspace', File.join(validator.validation_dir, 'App.xcworkspace'), '-scheme', 'JSONKit', '-configuration', 'Release']
        args = %w(CODE_SIGN_IDENTITY=)
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk appletvsimulator) + Fourflusher::SimControl.new.destination('Apple TV 1080p')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk iphonesimulator) + Fourflusher::SimControl.new.destination('iPhone 4s')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk xrsimulator) + Fourflusher::SimControl.new.destination('Apple Vision Pro')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk watchsimulator)
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        validator.validate.should == true
      end

      it 'runs xcodebuild with correct arguments when validating with --configuration' do
        require 'fourflusher'
        Fourflusher::SimControl.any_instance.stubs(:destination).returns(['-destination', 'id=XXX'])
        Validator.any_instance.unstub(:xcodebuild)
        stub_downloader_cache_rsync
        PodTarget.any_instance.stubs(:should_build?).returns(true)
        Installer::Xcode::PodsProjectGenerator::PodTargetInstaller.any_instance.stubs(:validate_targets_contain_sources) # since we skip downloading
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        validator.configuration = 'Debug'
        git = Executable.which(:git)
        Executable.stubs(:which).with('git').returns(git)
        Executable.stubs(:capture_command).with('git', ['config', '--get', 'remote.origin.url'], :capture => :out).returns(['https://github.com/CocoaPods/Specs.git'])
        Executable.stubs(:which).with(:xcrun)
        Executable.stubs(:execute_command).with('find', [validator.validation_dir, '-name', '*.html'], false).returns('')
        Executable.expects(:execute_command).with { |executable, command, _| executable == 'git' && command.first == 'clone' }.once
        # Command should '-configuration Debug' instead of '-configuration Release'.
        command = ['clean', 'build', '-workspace', File.join(validator.validation_dir, 'App.xcworkspace'), '-scheme', 'App', '-configuration', 'Debug']
        args = %w(CODE_SIGN_IDENTITY=)
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk appletvsimulator) + Fourflusher::SimControl.new.destination('Apple TV 1080p')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk iphonesimulator) + Fourflusher::SimControl.new.destination('iPhone 4s')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk xrsimulator) + Fourflusher::SimControl.new.destination('Apple Vision Pro')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk watchsimulator)
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        validator.validate.should == true
      end

      it 'runs xcodebuild with correct arguments when validating with --analyze' do
        require 'fourflusher'
        Fourflusher::SimControl.any_instance.stubs(:destination).returns(['-destination', 'id=XXX'])
        Validator.any_instance.unstub(:xcodebuild)
        stub_downloader_cache_rsync
        PodTarget.any_instance.stubs(:should_build?).returns(true)
        Installer::Xcode::PodsProjectGenerator::PodTargetInstaller.any_instance.stubs(:validate_targets_contain_sources) # since we skip downloading
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        validator.analyze = true
        git = Executable.which(:git)
        Executable.stubs(:which).with('git').returns(git)
        Executable.stubs(:capture_command).with('git', ['config', '--get', 'remote.origin.url'], :capture => :out).returns(['https://github.com/CocoaPods/Specs.git'])
        Executable.stubs(:which).with(:xcrun)
        Executable.stubs(:execute_command).with('find', [validator.validation_dir, '-name', '*.html'], false).returns('')
        Executable.expects(:execute_command).with { |executable, command, _| executable == 'git' && command.first == 'clone' }.once
        # Command should 'analyze' instead of 'build'.
        command = ['clean', 'analyze', '-workspace', File.join(validator.validation_dir, 'App.xcworkspace'), '-scheme', 'App', '-configuration', 'Release']
        args = %w(CODE_SIGN_IDENTITY=)
        analyzer_args = %w(CLANG_ANALYZER_OUTPUT=html)
        analyzer_args += %w(CLANG_ANALYZER_OUTPUT_DIR=analyzer)
        Executable.expects(:execute_command).with('xcodebuild', command + args + analyzer_args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk appletvsimulator) + Fourflusher::SimControl.new.destination('Apple TV 1080p') + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk iphonesimulator) + Fourflusher::SimControl.new.destination('iPhone 4s') + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk xrsimulator) + Fourflusher::SimControl.new.destination('Apple Vision Pro') + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk watchsimulator) + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        validator.validate.should == true
      end

      it 'runs xcodebuild with correct arguments when validating with --analyze and --configuration' do
        require 'fourflusher'
        Fourflusher::SimControl.any_instance.stubs(:destination).returns(['-destination', 'id=XXX'])
        Validator.any_instance.unstub(:xcodebuild)
        stub_downloader_cache_rsync
        PodTarget.any_instance.stubs(:should_build?).returns(true)
        Installer::Xcode::PodsProjectGenerator::PodTargetInstaller.any_instance.stubs(:validate_targets_contain_sources) # since we skip downloading
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        validator.analyze = true
        validator.configuration = 'Debug'
        git = Executable.which(:git)
        Executable.stubs(:which).with('git').returns(git)
        Executable.stubs(:capture_command).with('git', ['config', '--get', 'remote.origin.url'], :capture => :out).returns(['https://github.com/CocoaPods/Specs.git'])
        Executable.stubs(:which).with(:xcrun)
        Executable.stubs(:execute_command).with('find', [validator.validation_dir, '-name', '*.html'], false).returns('')
        Executable.expects(:execute_command).with { |executable, command, _| executable == 'git' && command.first == 'clone' }.once
        # Command should 'analyze' instead of 'build' and '-configuration Debug' instead of '-configuration Release'.
        command = ['clean', 'analyze', '-workspace', File.join(validator.validation_dir, 'App.xcworkspace'), '-scheme', 'App', '-configuration', 'Debug']
        args = %w(CODE_SIGN_IDENTITY=)
        analyzer_args = %w(CLANG_ANALYZER_OUTPUT=html)
        analyzer_args += %w(CLANG_ANALYZER_OUTPUT_DIR=analyzer)
        Executable.expects(:execute_command).with('xcodebuild', command + args + analyzer_args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk appletvsimulator) + Fourflusher::SimControl.new.destination('Apple TV 1080p') + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk iphonesimulator) + Fourflusher::SimControl.new.destination('iPhone 4s') + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk xrsimulator) + Fourflusher::SimControl.new.destination('Apple Vision Pro') + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk watchsimulator) + analyzer_args
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        validator.validate.should == true
      end

      it 'runs xcodebuild with correct arguments for code signing' do
        require 'fourflusher'
        Fourflusher::SimControl.any_instance.stubs(:destination).returns(['-destination', 'id=XXX'])
        Validator.any_instance.unstub(:xcodebuild)
        stub_downloader_cache_rsync
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        git = Executable.which(:git)
        Executable.stubs(:which).with('git').returns(git)
        Executable.stubs(:capture_command).with('git', ['config', '--get', 'remote.origin.url'], :capture => :out).returns(['https://github.com/CocoaPods/Specs.git'])
        Executable.stubs(:which).with(:xcrun)
        Executable.expects(:execute_command).with { |executable, command, _| executable == 'git' && command.first == 'clone' }.once
        command = ['clean', 'build', '-workspace', File.join(validator.validation_dir, 'App.xcworkspace'), '-scheme', 'App', '-configuration', 'Release']
        args = %w(CODE_SIGN_IDENTITY=)
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk appletvsimulator) + Fourflusher::SimControl.new.destination('Apple TV 1080p')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk iphonesimulator) + Fourflusher::SimControl.new.destination('iPhone 4s')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk xrsimulator) + Fourflusher::SimControl.new.destination('Apple Vision Pro')
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        args = %w(CODE_SIGN_IDENTITY=- -sdk watchsimulator)
        Executable.expects(:execute_command).with('xcodebuild', command + args, true).once.returns('')
        validator.validate
      end

      it 'sets the -Wincomplete-umbrella compiler flag for pod targets' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.no_clean = true
        validator.stubs(:check_file_patterns)
        validator.stubs(:validate_url)
        validator.validate

        pods_project = Xcodeproj::Project.open(validator.validation_dir + 'Pods/Pods.xcodeproj')

        pods_project.native_targets.find { |nt| nt.name == 'JSONKit' }.resolved_build_setting('OTHER_CFLAGS').each do |_, value|
          value.should == %w($(inherited) -Wincomplete-umbrella)
        end
      end

      it 'does filter InputFile errors completely' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:xcodebuild).returns("2014-10-01 06:27:36.693 xcodebuild[61207:2007] error: InputFile    Target Support Files/Pods-OneUpFoundation/Pods-OneUpFoundation-prefix.pch 0 1412159238 77 33188... malformed line 10; 'InputFile' should have exactly five arguments")
        validator.stubs(:validate_url)
        validator.validate
        validator.results.count.should == 0
      end

      it 'does filter embedded frameworks warnings' do
        validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        validator.stubs(:check_file_patterns)
        validator.stubs(:xcodebuild).returns('ld: warning: embedded dylibs/frameworks only run on iOS 8 or later.')
        validator.stubs(:validate_url)
        validator.validate
        validator.results.count.should == 0
      end

      describe 'import validation' do
        before do
          @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
          @validator.stubs(:validate_url)
          @consumer = Specification.from_file(podspec_path).consumer(:ios)
          @validator.instance_variable_set(:@consumer, @consumer)
          @validator.send(:setup_validation_environment)
        end

        after do
          @validator.send(:tear_down_validation_environment)
        end

        it 'creates an empty app project & target to integrate into' do
          @validator.use_frameworks = false
          @validator.send(:create_app_project)
          project = Xcodeproj::Project.open(@validator.validation_dir + 'App.xcodeproj')

          target = project.native_targets.find { |t| t.name == 'App' }
          target.should.not.be.nil
          target.symbol_type.should == :application
          target.deployment_target.should.be.nil
          target.platform_name.should == :ios
          target.build_configurations.each do |c|
            c.build_settings['INFOPLIST_FILE'].should == '$(SRCROOT)/App/App-Info.plist'
          end
          Xcodeproj::Project.schemes(project.path).should == %w(App)
        end

        it 'adds the importing file to the app target' do
          @validator.stubs(:use_frameworks).returns(true)
          @validator.send(:create_app_project)
          pods_project = Xcodeproj::Project.new(@validator.validation_dir + 'Pods/Pods.xcodeproj')
          app_project_path = @validator.validation_dir + 'App.xcodeproj'
          pod_target = fixture_pod_target('banana-lib/BananaLib.podspec')
          pod_target.stubs(:uses_swift? => true, :pod_name => 'JSONKit')
          installer = stub('Installer', :pod_targets => [pod_target], :pods_project => pods_project)
          Xcodeproj::XCScheme.expects(:share_scheme).with(app_project_path, 'App').once
          Xcodeproj::XCScheme.expects(:share_scheme).with(pods_project.path, 'BananaLib').once
          @validator.stubs(:shares_pod_target_xcscheme?).returns(true)
          @validator.instance_variable_set(:@installer, installer)
          @validator.send(:add_app_project_import)

          project = Xcodeproj::Project.open(@validator.validation_dir + 'App.xcodeproj')
          group = project['App']
          file = group.find_file_by_path('main.swift')
          file.should.not.be.nil
          target = project.native_targets.find { |t| t.name == 'App' }
          target.source_build_phase.files_references.should.include(file)
        end

        it 'adds developer framework paths when the pod depends on XCTest' do
          @validator.send(:create_app_project)
          pods_project = Xcodeproj::Project.new(@validator.validation_dir + 'Pods/Pods.xcodeproj')
          app_project_path = @validator.validation_dir + 'App.xcodeproj'
          pod_target = fixture_pod_target('banana-lib/BananaLib.podspec')
          pod_target.stubs(:uses_swift? => true, :pod_name => 'JSONKit')
          pod_target.spec_consumers.first.stubs(:frameworks).returns(%w(XCTest))
          installer = stub('Installer', :pod_targets => [pod_target], :pods_project => pods_project)
          Xcodeproj::XCScheme.expects(:share_scheme).with(app_project_path, 'App').once
          Xcodeproj::XCScheme.expects(:share_scheme).with(pods_project.path, 'BananaLib').once
          @validator.stubs(:shares_pod_target_xcscheme?).returns(true)
          @validator.instance_variable_set(:@installer, installer)
          @validator.send(:add_app_project_import)

          app_project = Xcodeproj::Project.open(app_project_path)
          app_project.native_targets.first.build_configurations.map do |bc|
            bc.build_settings['FRAMEWORK_SEARCH_PATHS']
          end.uniq.should == [%w($(inherited) "$(PLATFORM_DIR)/Developer/Library/Frameworks")]
        end

        it 'adds developer library paths when the pod depends on XCTest' do
          @validator.send(:create_app_project)
          pods_project = Xcodeproj::Project.new(@validator.validation_dir + 'Pods/Pods.xcodeproj')
          app_project_path = @validator.validation_dir + 'App.xcodeproj'
          pod_target = fixture_pod_target('banana-lib/BananaLib.podspec')
          pod_target.stubs(:uses_swift? => true, :pod_name => 'JSONKit')
          pod_target.spec_consumers.first.stubs(:frameworks).returns(%w(XCTest))
          installer = stub('Installer', :pod_targets => [pod_target], :pods_project => pods_project)
          Xcodeproj::XCScheme.expects(:share_scheme).with(app_project_path, 'App').once
          Xcodeproj::XCScheme.expects(:share_scheme).with(pods_project.path, 'BananaLib').once
          @validator.stubs(:shares_pod_target_xcscheme?).returns(true)
          @validator.instance_variable_set(:@installer, installer)
          @validator.send(:add_app_project_import)

          app_project = Xcodeproj::Project.open(app_project_path)
          app_project.native_targets.first.build_configurations.map do |bc|
            bc.build_settings['LIBRARY_SEARCH_PATHS']
          end.uniq.should == [%w($(inherited) "$(PLATFORM_DIR)/Developer/usr/lib")]
        end

        it 'does not add developer library paths when the pod depends on XCTest and deployment target after 12.2' do
          Specification.any_instance.stubs(:deployment_target).returns('13.0')

          @validator.send(:create_app_project)
          pods_project = Xcodeproj::Project.new(@validator.validation_dir + 'Pods/Pods.xcodeproj')
          app_project_path = @validator.validation_dir + 'App.xcodeproj'
          pod_target = fixture_pod_target('banana-lib/BananaLib.podspec')
          pod_target.stubs(:uses_swift? => true, :pod_name => 'JSONKit')
          pod_target.spec_consumers.first.stubs(:frameworks).returns(%w(XCTest))
          installer = stub('Installer', :pod_targets => [pod_target], :pods_project => pods_project)
          Xcodeproj::XCScheme.expects(:share_scheme).with(app_project_path, 'App').once
          Xcodeproj::XCScheme.expects(:share_scheme).with(pods_project.path, 'BananaLib').once
          @validator.stubs(:shares_pod_target_xcscheme?).returns(true)
          @validator.instance_variable_set(:@installer, installer)
          @validator.send(:add_app_project_import)

          app_project = Xcodeproj::Project.open(app_project_path)
          app_project.native_targets.first.build_configurations.map do |bc|
            bc.build_settings['LIBRARY_SEARCH_PATHS']
          end.uniq.should == [nil]
        end

        it 'does not share xcscheme for pod target if there isnt one' do
          @validator.send(:create_app_project)
          pods_project = Xcodeproj::Project.new(@validator.validation_dir + 'Pods/Pods.xcodeproj')
          app_project_path = @validator.validation_dir + 'App.xcodeproj'
          pod_target = fixture_pod_target('banana-lib/BananaLib.podspec')
          pod_target.stubs(:uses_swift? => true, :pod_name => 'JSONKit')
          pod_target.spec_consumers.first.stubs(:frameworks).returns(%w(XCTest))
          installer = stub('Installer', :pod_targets => [pod_target], :pods_project => pods_project)
          Xcodeproj::XCScheme.expects(:share_scheme).with(app_project_path, 'App').once
          Xcodeproj::XCScheme.expects(:share_scheme).with(pods_project.path, 'BananaLib').never
          @validator.stubs(:shares_pod_target_xcscheme?).returns(false)
          @validator.instance_variable_set(:@installer, installer)
          @validator.send(:add_app_project_import)
        end
      end

      describe 'file pattern validation' do
        it 'checks for file patterns' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "wrong_paht.*",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /source_files.*did not match/
          validator.result_type.should == :error
        end

        it 'checks private_header_files matches only headers' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "private_header_files": "JSONKit.m",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /matches non-header files \(JSONKit\.m\)/
          validator.result_type.should == :error
        end

        it 'checks public_header_files matches only headers' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "public_header_files": "JSONKit.m",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /matches non-header files \(JSONKit\.m\)/
          validator.result_type.should == :error
        end

        it 'warns if public_header_files does not match any files' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "public_header_files": "MissingHeader.h",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /The `public_header_files` pattern did not match any file./
          validator.result_type.should == :warning
        end

        it 'warns if project_header_files does not match any files' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "project_header_files": "MissingHeader.h",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /The `project_header_files` pattern did not match any file./
          validator.result_type.should == :warning
        end

        it 'warns if private_header_files does not match any files' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "private_header_files": "MissingHeader.h",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /The `private_header_files` pattern did not match any file./
          validator.result_type.should == :warning
        end

        it 'checks presence of license file' do
          file = write_podspec(stub_podspec(/.*license.*$/, '"license": "MIT",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /Unable to find a license file/
          validator.result_type.should == :warning
        end

        it 'checks module_map must exist if specified' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "module_map": "JSONKit.modulemap",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /Unable to find the specified module map file./
          validator.result_type.should == :error
        end

        it 'checks module_map accepts only modulemaps' do
          file = write_podspec(stub_podspec(/.*source_files.*/, '"source_files": "JSONKit.*", "module_map": "JSONKit.m",'))
          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.match /Unexpected file extension for modulemap file \(JSONKit\.m\)/
          validator.result_type.should == :error
        end

        it 'checks resource bundles have resources' do
          file = write_podspec(stub_podspec(/.*source_files.*/, <<-JSON))
            "source_files": "JSONKit.*",
            "resource_bundles": {
              "bundle1": ["CHANGELOG.md", "*.md"],
              "bundle2": "foo.bar*"
            },
          JSON

          validator = Validator.new(file, config.sources_manager.master.map(&:url))
          validator.stubs(:build_pod)
          validator.stubs(:validate_url)
          validator.validate
          validator.results.map(&:to_s).first.should.include 'The `resource_bundles` pattern for `bundle2` did not match any file'
          validator.result_type.should == :error
        end
      end

      it 'validates a podspec with dependencies' do
        podspec = stub_podspec(/.*name.*/, '"name": "SBJson",').gsub(/.*version.*/, '"version": "3.2",')
        file = write_podspec(podspec, 'SBJson.podspec.json')
        spec = Specification.from_file(file)
        set = mock
        set.stubs(:all_specifications).returns([spec])
        Source::Aggregate.any_instance.stubs(:search).with(Dependency.new('SBJson', '~> 3.2')).returns(set)

        podspec = stub_podspec(/.*name.*/, '"name": "ZKit",')
        podspec.gsub!(/.*requires_arc.*/, '"dependencies": { "SBJson": [ "~> 3.2" ] }, "requires_arc": false')
        file = write_podspec(podspec, 'ZKit.podspec.json')

        spec = Specification.from_file(file)
        validator = Validator.new(spec, config.sources_manager.master.map(&:url))
        validator.stubs(:validate_url)
        validator.stubs(:build_pod)
        validator.validate
        validator.validated?.should.be.true
      end

      it 'validates a podspec with non-ascii pod name' do
        Installer::Xcode::PodsProjectGenerator::PodTargetInstaller.any_instance.stubs(:validate_targets_contain_sources) # since we skip downloading
        podspec = stub_podspec(/.*name.*/, '"name": "※ikemen",')
        file = write_podspec(podspec, '※ikemen.podspec.json')
        # xcodebuild output on macOS Catalina 10.15 (system ruby) may include non-ascii characters in ASCII-8BIT String
        xcodebuild_output = "note: Execution policy exception registration failed and was skipped: Error Domain=NSPOSIXErrorDomain Code=1 \"Operation not permitted\" (in target '※ikemen' from project 'Pods')".force_encoding('ASCII-8BIT')

        Validator.any_instance.unstub(:xcodebuild)
        validator = Validator.new(file, config.sources_manager.master.map(&:url), [:osx])
        validator.stubs(:validate_url)
        validator.stubs(:_xcodebuild).returns(xcodebuild_output)
        validator.validate
        validator.validated?.should.be.true
      end
    end

    describe 'frameworks' do
      before do
        @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
      end

      def setup_validator
        @validator.instance_variable_set(:@results, [])
        @validator.stubs(:validate_url)
        @validator.stubs(:validate_screenshots)
        @validator.stubs(:check_file_patterns)
        @validator.stubs(:install_pod)
        @validator.stubs(:add_app_project_import)
        %i(prepare resolve_dependencies download_dependencies write_lockfiles).each do |m|
          Installer.any_instance.stubs(m)
        end
        Installer.any_instance.stubs(:aggregate_targets).returns([])
        Installer.any_instance.stubs(:pod_targets).returns([])
      end

      it 'lints as a framework if specified' do
        @validator.use_frameworks = true

        setup_validator

        @validator.expects(:podfile_from_spec).with(:osx, nil, true, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:ios, '8.0', true, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:tvos, nil, true, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:visionos, nil, true, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:watchos, nil, true, [], nil, nil).once.returns(stub('Podfile'))
        @validator.send(:perform_extensive_analysis, @validator.spec)

        @validator.results_message.strip.should.be.empty
      end

      it 'lint as a static library if specified' do
        @validator.use_frameworks = false

        setup_validator

        @validator.expects(:podfile_from_spec).with(:osx, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:ios, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:tvos, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:visionos, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        @validator.expects(:podfile_from_spec).with(:watchos, nil, false, [], nil, nil).once.returns(stub('Podfile'))
        @validator.send(:perform_extensive_analysis, @validator.spec)

        @validator.results_message.strip.should.be.empty
      end

      it 'shows an error when performing extensive analysis on a test spec' do
        setup_validator
        subspec = Specification.new(@validator.spec, 'Tests', true)
        @validator.send(:perform_extensive_analysis, subspec)
        @validator.results.map(&:to_s).first.should.include 'Validating a non library spec (`JSONKit/Tests`) is not supported.'
        @validator.result_type.should == :error
      end

      it 'shows an error when performing extensive analysis on an app spec' do
        setup_validator
        subspec = Specification.new(@validator.spec, 'App', :app_specification => true)
        @validator.send(:perform_extensive_analysis, subspec)
        @validator.results.map(&:to_s).first.should.include 'Validating a non library spec (`JSONKit/App`) is not supported.'
        @validator.result_type.should == :error
      end
    end

    describe 'dynamic binaries validation' do
      it 'fails with dynamic binaries on iOS < 8' do
        podspec = stub_podspec(/.*license.*$/, '"license": "Public Domain",')
        file = write_podspec(podspec)

        Pod::Sandbox::FileAccessor.any_instance.stubs(:vendored_libraries).returns([fixture('empty.dylib')])
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.stubs(:build_pod)
        validator.stubs(:validate_url)
        validator.validate

        validator.results.count.should == 2
        validator.results.map(&:to_s)[0].should.match /`empty\.dylib` does not match the expected library name format/
        validator.results.map(&:to_s)[1].should.match /Dynamic frameworks.*iOS 8.0 and onwards/
        validator.result_type.should == :error
      end

      it 'uses the expanded paths of the vendored libraries to validate them' do
        podspec = stub_podspec(/.*source_files.*/, "  \"source_files\": \"JSONKit.*\",\n  \"vendored_libraries\": \"**/*.a\",")
        file = write_podspec(podspec)

        Pod::Sandbox::FileAccessor.any_instance.stubs(:vendored_libraries).returns([fixture('monkey/monkey.a'), fixture('banana-lib/libBananaStaticLib.a')])
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.stubs(:build_pod)
        validator.stubs(:validate_url)
        validator.validate

        validator.results.count.should == 1
        validator.results.map(&:to_s).first.should.match /`monkey\.a` does not match the expected library name format/
        validator.result_type.should == :warning
      end
    end

    describe 'additional podspecs' do
      it 'supports providing ancillary :path based pods via a glob' do
        @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))

        coconut_spec_path = SpecHelper::Fixture.fixture('coconut-lib/CoconutLib.podspec')
        @validator.include_podspecs = coconut_spec_path

        podfile = @validator.send(:podfile_from_spec, :ios, '5.0')

        coconut_dep = podfile.target_definitions['App'].dependencies[1]
        coconut_dep.name.should == 'CoconutLib'
        coconut_dep.local?.should.not.nil?
      end

      it 'supports providing ancillary :podspec based pods via a glob' do
        @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))

        coconut_spec_path = SpecHelper::Fixture.fixture('coconut-lib/CoconutLib.podspec')
        @validator.external_podspecs = coconut_spec_path

        podfile = @validator.send(:podfile_from_spec, :ios, '5.0')

        coconut_dep = podfile.target_definitions['App'].dependencies[1]
        coconut_dep.name.should == 'CoconutLib'
        coconut_dep.local?.should.nil?
        coconut_dep.external?.should.not.nil?
      end

      it 'does not include the main spec in include_podspecs' do
        @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
        @validator.include_podspecs = podspec_path

        podfile = @validator.send(:podfile_from_spec, :ios, '5.0')

        podfile.target_definitions['App'].dependencies.length.should == 1
      end

      it 'removes external_podspecs from include_podspecs to ensure they only turn up once' do
        @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))

        @validator.include_podspecs = podspec_path
        @validator.external_podspecs = podspec_path

        podfile = @validator.send(:podfile_from_spec, :ios, '5.0')

        podfile.target_definitions['App'].dependencies.length.should == 2
      end
    end

    describe 'swift validation' do
      def stub_swift_podspec
        stub_podspec(/.*source_files.*/, '"source_files": "*.swift",')
      end

      def test_validator(podspec)
        file = write_podspec(podspec)
        pathname = Pathname.new('/Foo.swift')
        pathname.stubs(:realpath).returns(pathname)

        Podfile::TargetDefinition.any_instance.stubs(:uses_frameworks?).returns(true)
        Pod::Sandbox::FileAccessor.any_instance.stubs(:source_files).returns([pathname])
        Pod::Installer::PodSourceInstaller.any_instance.stubs(:lock_files!)
        Pod::Installer::PodSourceInstaller.any_instance.stubs(:unlock_files!)
        validator = Validator.new(file, config.sources_manager.master.map(&:url))
        validator.stubs(:build_pod)
        validator.stubs(:validate_url)
        validator
      end

      # Creates a test fixture using the `--swift-version` parameter.
      def test_swiftpod_with_swift_version_parameter(swift_version = '3.1.0')
        validator = test_validator(stub_swift_podspec)
        validator.swift_version = swift_version
        validator
      end

      # Creates a test fixture using a `.swift-version` file.
      def test_swiftpod_with_dot_swift_version_file(dot_swift_version = '3.1.0')
        validator = test_validator(stub_swift_podspec)
        validator.stubs(:dot_swift_version).returns(dot_swift_version)
        validator
      end

      # Creates a test fixture using the `swift_versions` DSL.
      def test_swiftpod_with_swift_version_dsl(swift_versions = ['3.1.0'])
        podspec = stub_swift_podspec
        podspec.gsub!(/.*requires_arc.*/, "\"swift_versions\": [ #{swift_versions.map { |v| "\"#{v}\"" }.join(', ')} ], \"requires_arc\": false")
        test_validator(podspec)
      end

      it 'fails on deployment target < iOS 8 for Swift Pods' do
        validator = test_swiftpod_with_dot_swift_version_file
        validator.validate

        validator.results.map(&:to_s).first.should.match /dynamic frameworks.*iOS > 8/
        validator.result_type.should == :error
      end

      it 'succeeds on deployment target < iOS 8 for Swift Pods using XCTest' do
        Specification::Consumer.any_instance.stubs(:frameworks).returns(%w(XCTest))

        validator = test_swiftpod_with_dot_swift_version_file
        validator.validate
        validator.results.count.should == 0
      end

      it 'succeeds on deployment targets >= iOS 8 for Swift Pods' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_swiftpod_with_dot_swift_version_file
        validator.validate

        validator.results.count.should == 0
      end

      it 'succeeds with a --swift-version provided value' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_swiftpod_with_swift_version_parameter('3.1.0')
        validator.validate
        validator.results.count.should == 0
      end

      it 'succeeds with a .swift-version file' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_swiftpod_with_dot_swift_version_file
        validator.validate
        validator.results.count.should == 0
      end

      it 'does not warn to use swift_versions attribute if the pod does not use Swift' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_validator(stub_podspec)
        Pod::Sandbox::FileAccessor.any_instance.unstub(:source_files)
        validator.stubs(:dot_swift_version).returns('3.2')
        validator.validate

        validator.results.count.should == 0
        UI.warnings.should.be.empty
      end

      it 'warns that the default swift version was used if none was provided' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_validator(stub_swift_podspec)
        validator.validate
        validator.results.count.should == 1

        result = validator.results.first
        result.type.should == :warning
        result.message.should == 'The validator used ' \
        'Swift `4.0` by default because no Swift version was specified. ' \
        'To specify a Swift version during validation, add the `swift_versions` attribute in your podspec. ' \
        'Note that usage of a `.swift-version` file is now deprecated.'
      end

      it 'warns when a dot swift version file is used instead of the swift_versions attribute' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_swiftpod_with_dot_swift_version_file('3.2')
        validator.validate

        UI.warnings.should.include 'Usage of the `.swift_version` file has been deprecated! Please delete the ' \
          'file and use the `swift_versions` attribute within your podspec instead.'
      end

      it 'errors when swift version spec attribute does not match dot swift version' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')
        Specification.any_instance.stubs(:swift_versions).returns([Version.new('3.0'), Version.new('4.0')])

        validator = test_swiftpod_with_dot_swift_version_file('3.2')
        validator.validate
        validator.results.count.should == 1

        result = validator.results.first
        result.type.should == :error
        result.message.should == 'Specification `JSONKit` specifies inconsistent `swift_versions` (`3.0` and `4.0`) compared to the one present in your `.swift-version` file (`3.2`). ' \
                               'Please remove the `.swift-version` file which is now deprecated and only use the `swift_versions` attribute within your podspec.'
      end

      it 'does not error when swift version spec attribute includes dot swift version' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')
        Specification.any_instance.stubs(:swift_versions).returns([Version.new('4.0')])

        validator = test_swiftpod_with_dot_swift_version_file('4.0')
        validator.validate
        validator.results.count.should == 0
      end

      it 'errors when swift version spec attribute does not match parameter based swift version' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')
        Specification.any_instance.stubs(:swift_versions).returns([Version.new('3.0'), Version.new('4.0')])

        validator = test_swiftpod_with_swift_version_parameter('3.2')
        validator.validate
        validator.results.count.should == 1

        result = validator.results.first
        result.type.should == :error
        result.message.should == 'Specification `JSONKit` specifies inconsistent `swift_versions` (`3.0` and `4.0`) compared to the one passed during lint (`3.2`).'
      end

      it 'does not error when swift version spec attribute matches parameter based swift version' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')
        Specification.any_instance.stubs(:swift_versions).returns([Version.new('4.0')])

        validator = test_swiftpod_with_swift_version_parameter('4.0')
        validator.validate
        validator.results.count.should == 0
      end

      it 'does not warn for Swift if version was set by a dot swift version file' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_swiftpod_with_dot_swift_version_file
        validator.validate
        validator.results.count.should == 0
      end

      it 'does not warn for Swift if version was set as a parameter' do
        Specification.any_instance.stubs(:deployment_target).returns('9.0')

        validator = test_swiftpod_with_swift_version_parameter('3.1.0')
        validator.stubs(:dot_swift_version).returns(nil)
        validator.validate
        validator.results.count.should == 0
      end

      describe '#derived_swift_version' do
        it 'defaults to Swift 4.0' do
          validator = test_swiftpod_with_swift_version_parameter(nil)
          validator.stubs(:dot_swift_version).returns(nil)
          validator.derived_swift_version.should == '4.0'
        end

        it 'uses the Swift version specified by the swift_version attribute in the spec' do
          validator = test_swiftpod_with_swift_version_parameter(nil)
          validator.spec.swift_version = '4.0'
          validator.derived_swift_version.should == '4.0'
        end

        it 'allows the user to set the Swift version using a .swift-version file' do
          validator = test_swiftpod_with_swift_version_parameter('4.0')
          validator.stubs(:dot_swift_version).returns('3.0')
          validator.derived_swift_version.should == '4.0'
        end

        it 'checks for dot_swift_version' do
          validator = test_swiftpod_with_swift_version_parameter(nil)
          validator.expects(:dot_swift_version)
          validator.derived_swift_version
        end

        it 'uses the result of dot_swift_version if not nil' do
          validator = test_swiftpod_with_swift_version_parameter(nil)
          validator.stubs(:dot_swift_version).returns('1.0')
          validator.derived_swift_version.should == '1.0'
        end
      end

      describe '#dot_swift_version' do
        it 'looks for a .swift-version file' do
          validator = test_validator(stub_swift_podspec)
          Pathname.any_instance.expects(:exist?)
          validator.dot_swift_version
        end

        it 'uses the .swift-version file if present' do
          validator = test_validator(stub_swift_podspec)
          Pathname.any_instance.stubs(:exist?).returns(true)
          Pathname.any_instance.expects(:read).returns('1.0')
          validator.dot_swift_version.should == '1.0'
        end

        it 'strips newlines from .swift-version files' do
          validator = test_validator(stub_swift_podspec)
          Pathname.any_instance.stubs(:exist?).returns(true)
          Pathname.any_instance.stubs(:read).returns("2.1\n")
          validator.dot_swift_version.should == '2.1'
        end
      end

      describe 'Getting the Swift value used by the validator' do
        it 'passes nil when no targets have used Swift' do
          validator = test_swiftpod_with_swift_version_parameter
          pod_target = stub(:uses_swift? => true)
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)

          validator.stubs(:dot_swift_version).returns('1.2.3')
          validator.uses_swift?.should.be.true
        end

        it 'returns the swift_version when a target has used Swift' do
          validator = test_swiftpod_with_swift_version_parameter
          pod_target = stub(:uses_swift? => false)
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)

          validator.uses_swift?.should.be.false
        end

        it 'honors the swift version DSL by the pod target' do
          validator = test_swiftpod_with_swift_version_dsl(['3.0', '4.0'])
          consumer = stub(:platform_name => 'iOS')
          validator.instance_variable_set(:@consumer, consumer)
          debug_configuration = stub(:build_settings => {})
          native_target = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration]))
          pod_target = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target_installation_one = stub(:target => pod_target, :native_target => native_target,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_results = { 'JSONKit' => pod_target_installation_one }
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration.build_settings['SWIFT_VERSION'].should == '4.0'
        end

        it 'honors the swift version parameter above DSL and .swift-version file if set' do
          validator = test_swiftpod_with_swift_version_dsl(['3.0', '4.0'])
          validator.stubs(:dot_swift_version).returns('4.1')
          validator.swift_version = '4.2'
          consumer = stub(:platform_name => 'iOS')
          validator.instance_variable_set(:@consumer, consumer)
          debug_configuration = stub(:build_settings => {})
          native_target = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration]))
          pod_target = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target_installation_one = stub(:target => pod_target, :native_target => native_target,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_results = { 'JSONKit' => pod_target_installation_one }
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration.build_settings['SWIFT_VERSION'].should == '4.2'
        end

        it 'does not honor the .swift-version file if the DSL is set' do
          validator = test_swiftpod_with_swift_version_dsl(['3.0', '4.0'])
          validator.stubs(:dot_swift_version).returns('4.2')
          consumer = stub(:platform_name => 'iOS')
          validator.instance_variable_set(:@consumer, consumer)
          debug_configuration = stub(:build_settings => {})
          native_target = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration]))
          pod_target = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target_installation_one = stub(:target => pod_target, :native_target => native_target,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_results = { 'JSONKit' => pod_target_installation_one }
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration.build_settings['SWIFT_VERSION'].should == '4.0'
        end

        it 'does not honor the .swift-version file if the swift version parameter is set' do
          validator = test_swiftpod_with_swift_version_parameter('4.0')
          validator.stubs(:dot_swift_version).returns('4.2')
          consumer = stub(:platform_name => 'iOS')
          validator.instance_variable_set(:@consumer, consumer)
          debug_configuration = stub(:build_settings => {})
          native_target = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration]))
          pod_target = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target_installation_one = stub(:target => pod_target, :native_target => native_target,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_results = { 'JSONKit' => pod_target_installation_one }
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration.build_settings['SWIFT_VERSION'].should == '4.0'
        end

        it 'honors swift version DSL into test specifications' do
          test_podspec = stub_swift_podspec
          validator = test_swiftpod_with_swift_version_dsl(['3.0', '4.2'])
          consumer = stub(:platform_name => 'iOS')
          validator.instance_variable_set(:@consumer, consumer)
          debug_configuration = stub(:build_settings => {})
          test_debug_configuration = stub(:build_settings => {})
          native_target = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration]))
          test_native_target = stub(:build_configuration_list => stub(:build_configurations => [test_debug_configuration]))
          pod_target = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target.stubs(:uses_swift_for_spec?).with(test_podspec).returns(true)
          pod_target_installation = stub(:target => pod_target, :native_target => native_target,
                                         :test_native_targets => [test_native_target],
                                         :test_specs_by_native_target => { test_native_target => test_podspec })
          pod_target_installation_results = { 'PodTarget' => pod_target_installation }
          installer = stub(:pod_targets => [pod_target])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration.build_settings['SWIFT_VERSION'].should == '4.2'
          test_debug_configuration.build_settings['SWIFT_VERSION'].should == '4.2'
        end

        it 'honors the swift version set for dependencies ignoring swift version of the target being validated' do
          validator = test_swiftpod_with_swift_version_parameter('4.0')
          debug_configuration_one = stub(:build_settings => {})
          debug_configuration_two = stub(:build_settings => {})
          native_target_one = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_one]))
          native_target_two = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_two]))
          pod_target_one = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target_two = stub(:name => 'Dependency', :uses_swift? => true, :pod_name => 'Dependency',
                                :spec_swift_versions => [], :swift_version => '3.2')
          pod_target_installation_one = stub(:target => pod_target_one, :native_target => native_target_one,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_two = stub(:target => pod_target_two, :native_target => native_target_two,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_results = { 'PodTarget1' => pod_target_installation_one, 'PodTarget2' => pod_target_installation_two }
          installer = stub(:pod_targets => [pod_target_one, pod_target_two])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration_one.build_settings['SWIFT_VERSION'].should == '4.0'
          debug_configuration_two.build_settings['SWIFT_VERSION'].should == '3.2'
        end

        it 'honors the swift version set for dependencies if they support it' do
          validator = test_swiftpod_with_swift_version_parameter('4.0')
          debug_configuration_one = stub(:build_settings => {})
          debug_configuration_two = stub(:build_settings => {})
          native_target_one = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_one]))
          native_target_two = stub(:build_configuration_list => stub(:build_configurations => [debug_configuration_two]))
          pod_target_one = stub(:name => 'JSONKit', :uses_swift? => true, :pod_name => 'JSONKit')
          pod_target_two = stub(:name => 'Dependency', :uses_swift? => true, :pod_name => 'Dependency',
                                :spec_swift_versions => ['4.0'], :swift_version => '3.2')
          pod_target_installation_one = stub(:target => pod_target_one, :native_target => native_target_one,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_two = stub(:target => pod_target_two, :native_target => native_target_two,
                                             :test_native_targets => [], :test_specs_by_native_target => {})
          pod_target_installation_results = { 'PodTarget1' => pod_target_installation_one, 'PodTarget2' => pod_target_installation_two }
          installer = stub(:pod_targets => [pod_target_one, pod_target_two])
          validator.instance_variable_set(:@installer, installer)
          validator.send(:configure_pod_targets, [pod_target_installation_results])
          debug_configuration_one.build_settings['SWIFT_VERSION'].should == '4.0'
          debug_configuration_two.build_settings['SWIFT_VERSION'].should == '4.0'
        end
      end

      # Given a validator and a consumer, creates an App project and returns it's main target
      def create_target_with_validator_consumer(validator, consumer)
        validator.instance_variable_set(:@consumer, consumer)
        validator.send(:setup_validation_environment)
        validator.send(:create_app_project)
        project = Xcodeproj::Project.open(validator.validation_dir + 'App.xcodeproj')

        project.native_targets.find { |t| t.name == 'App' }
      end

      describe 'sets various configuration settings' do
        before do
          @validator = Validator.new(podspec_path, config.sources_manager.master.map(&:url))
          @validator.stubs(:validate_url)
        end

        after do
          @validator.send(:tear_down_validation_environment)
        end

        describe 'sets the product bundle identifier' do
          it 'ios platform sets product bundle identifier' do
            consumer = Specification.from_file(podspec_path).consumer(:ios)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings['PRODUCT_BUNDLE_IDENTIFIER'].should == 'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}'
            end
          end

          it 'tvos platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:tvos)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings['PRODUCT_BUNDLE_IDENTIFIER'].should == 'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}'
            end
          end

          it 'osx platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:osx)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings['PRODUCT_BUNDLE_IDENTIFIER'].should == 'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}'
            end
          end

          it 'watchos platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:watchos)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings['PRODUCT_BUNDLE_IDENTIFIER'].should == 'org.cocoapods.${PRODUCT_NAME:rfc1034identifier}'
            end
          end
        end

        describe 'check appicon key deleted' do
          it 'ios platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:ios)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings.key?('ASSETCATALOG_COMPILER_APPICON_NAME').should.be.false
            end
          end

          it 'tvos platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:tvos)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings.key?('ASSETCATALOG_COMPILER_APPICON_NAME').should.be.false
            end
          end

          it 'osx platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:osx)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings.key?('ASSETCATALOG_COMPILER_APPICON_NAME').should.be.false
            end
          end

          it 'watchos platform deletes AppIcon key' do
            consumer = Specification.from_file(podspec_path).consumer(:watchos)
            target = create_target_with_validator_consumer(@validator, consumer)

            target.build_configurations.each do |config|
              config.build_settings.key?('ASSETCATALOG_COMPILER_APPICON_NAME').should.be.false
            end
          end
        end
      end
    end

    #-------------------------------------------------------------------------#
  end
end