Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add booth-cfg-name attribute to ticket #135

Closed
jfriesse opened this issue Feb 5, 2024 · 0 comments · Fixed by #141
Closed

Add booth-cfg-name attribute to ticket #135

jfriesse opened this issue Feb 5, 2024 · 0 comments · Fixed by #141
Labels
Enhancement

Comments

@jfriesse
Copy link
Member

jfriesse commented Feb 5, 2024

This is mostly to be able to mark what tickets were created by booth and what specific booth instance it was. The idea is mostly to allow pcs remove booth tickets, which were removed from config. It is questionable if booth itself should cleanup old (in config file non-existing) tickets or not, but if so, this can be different issue/PR/commit.

booth-cfg-name should be same as used in pid file so booth_conf->name

More context can be found in https://issues.redhat.com/browse/RHEL-7602
jfriesse added a commit to jfriesse/booth that referenced this issue May 30, 2024
@jfriesse
pacemaker: Store booth-cfg-name attribute
27bb52a 
This can be useful to find out if ticket is managed by booth and what
specific booth instance. So cluster configuration tools can delete CIB
ticket when removing ticket from booth configuration.

Fixes ClusterLabs#135

Signed-off-by: Jan Friesse <jfriesse@redhat.com>
@jfriesse jfriesse mentioned this issue May 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pacemaker: Store booth-cfg-name attribute jfriesse/booth
1 participant
@jfriesse