Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript support for Sveltekit #144

Open
silveltman opened this issue Apr 3, 2023 · 1 comment
Open

Add typescript support for Sveltekit #144

silveltman opened this issue Apr 3, 2023 · 1 comment

Comments

@silveltman
Copy link

After setting the whole thing up, I found out that running the bookshop browser on components using typescript gives an error:

bookshop-import-file:components/sample/sample.svelte__bookshop_file__:1:17: note: The plugin "esbuild-svelte" was triggered by this import
    1 │ import file from "./components/sample/sample. Svelte";

sample.svelte:

<script lang="ts">
	export let text: 'test' | string = 'hello world'
</script>

<div class="c-sample bg-neutral-500 ">
	<p class="py">{text} hello</p>
</div>

Does this mean typescript is currently not supported at all?

@bglw
Copy link
Contributor

bglw commented Apr 5, 2023

Hmm I haven't explicitly added any typescript support so I assume it isn't getting through Bookshop's loaders. I'll look into this, it should be possible 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants