Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the Expression double conversion operator to handle string values #1359

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Fixed the Expression double conversion operator to handle string values #1359

merged 1 commit into from
Mar 21, 2020

Conversation

mathlang
Copy link
Contributor

@mathlang mathlang commented Mar 2, 2020

Fixes issue #1358

@mathlang mathlang force-pushed the issue1358-subexpressions branch 2 times, most recently from 091cfde to 3246f97 Compare March 2, 2020 22:50
@igitur
Copy link
Member

igitur commented Mar 3, 2020

Please check whether #1233 doesn't already address this issue.

@mathlang
Copy link
Contributor Author

mathlang commented Mar 3, 2020

It looks like #1233 has the same issue. It's the same code that was moved to a new ConvertibleObject class. I commented in #1233.

@Pankraty Pankraty mentioned this pull request Mar 12, 2020
Open
@igitur igitur merged commit 12f2039 into ClosedXML:develop Mar 21, 2020
@igitur
Copy link
Member

igitur commented Mar 21, 2020

Thanks for a good contribution. Keep them coming.

@igitur igitur added this to the v0.95 milestone Mar 21, 2020
@mathlang mathlang mentioned this pull request Mar 24, 2020
Closed
3 tasks
@igitur igitur added the bug label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igitur igitur igitur left review comments

@Pankraty Pankraty Pankraty approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.95
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathlang @igitur @Pankraty