Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a regular expression used for extracting A1 references #1356

Merged
merged 1 commit into from
Mar 2, 2020
Merged

Fix a regular expression used for extracting A1 references #1356

merged 1 commit into from
Mar 2, 2020

Conversation

Pankraty
Copy link
Member

@Pankraty Pankraty commented Mar 2, 2020

Fixes #1355

@Pankraty
Fix a regular expressions used for extracting A1 references from form…
ede7f41 
…ulas to correctly process functions like ATAN2 or DEC2HEX
@Pankraty Pankraty changed the title Fix a regular expressions used for extracting A1 references Fix a regular expression used for extracting A1 references Mar 2, 2020
@igitur
Copy link
Member

igitur commented Mar 2, 2020

I'm concerned by the performance of these complex regular expressions. Hopefully, one day, when we have a proper formula repository, we can get rid of these.

@igitur igitur added this to the v0.95 milestone Mar 2, 2020
@igitur igitur merged commit 9e9ee24 into ClosedXML:develop Mar 2, 2020
@igitur igitur added the bug label Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igitur igitur igitur approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.95
Development

Successfully merging this pull request may close these issues.

delete column will change formula
2 participants
@Pankraty @igitur