Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exception when loading rows with no row index populated (#1314) #1316

Merged
merged 1 commit into from
Feb 11, 2020

Conversation

TimGreaves
Copy link
Contributor

I have moved the initialisation of the lastRow outside of the loading loop to ensure that it increments correctly as subsequent rows are loaded in.

Fixes #1314

@Pankraty
Copy link
Member

Pankraty commented Dec 3, 2019

Thank you for the contribution!

@Pankraty Pankraty added the bug label Dec 3, 2019
@igitur igitur added this to the v0.95 milestone Feb 11, 2020
@igitur igitur merged commit 5d2f5df into ClosedXML:develop Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worksheets where rows do not have the row number attribute set fail to load correctly.
3 participants