Redefine rules for sheet name escaping (#1287) #1292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igitur
reviewed
Feb 10, 2020
|
#1194 is merged. Please rebase. |
Pankraty
force-pushed
the
1287-RepeatOnTop
branch
from
b526b64
to
f069b47
Compare
Pankraty
force-pushed
the
1287-RepeatOnTop
branch
from
f069b47
to
c15bce7
Compare
igitur
reviewed
Mar 28, 2020
| [TestCase("한국어", ExpectedResult = "한국어")] | ||
| [TestCase("Slovenščina", ExpectedResult = "Slovenščina")] | ||
| [TestCase("", ExpectedResult = "")] | ||
| [TestCase(null, ExpectedResult = null)] |
igitur
approved these changes
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1287
Depends on #1194
(will do a rebase after it is merged)Here I joined together two classes both called
StringExtensions, made all their methods internal (classes were internal anyway), rewrote the rules for sheet name escaping and provided a bunch of tests.