Fix issues related to cells inserting (1236) #1247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1236, but also
InsertCellsBefore
caused unnecessary initialization of all cells prior to the last cell in a rowMaxColumnUsed
andMaxRowUsed
were not recalculated once row/column got deletedDecrementUsage
was called twice withrow
passed:(I could not manage to find evident bugs caused by this, but I am pretty sure they might exist)