Merged ranges cell values should not be set, except for top left cell of merged range #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pankraty
requested changes
Jun 14, 2019
|
Beside to cell value and formulas, I think we have to also process styles, comments, sparklines (once they're implemented), maybe something else. But this, of course, has a lower priority. |
|
Urgh, how did I forget about formulas! Of course! I'm not convinced about the others though. Would keeping styles, etc have any effect on other dependent cells? Values and formulas affect dependent cells, so we definitely need exclusion for them. |
igitur
force-pushed
the
issue1229-merged-cells-setvalue
branch
2 times, most recently
from
689850e
to
b67aeda
Compare
…top left cell of merged range
igitur
force-pushed
the
issue1229-merged-cells-setvalue
branch
from
b67aeda
to
4bbbbdc
Compare
Pankraty
approved these changes
Jul 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1229