Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear all RelId's if workbook is loaded from template. #1172

Merged
merged 1 commit into from
Apr 4, 2019
Merged

Clear all RelId's if workbook is loaded from template. #1172

merged 1 commit into from
Apr 4, 2019

Conversation

igitur
Copy link
Member

@igitur igitur commented Apr 4, 2019

If a workbook is loaded with XLWorkbook.OpenFromTemplate(), it should be treated as brand new, i.e. no RelId's should be prepopulated.

@igitur igitur added this to the v0.96 milestone Apr 4, 2019
@igitur igitur requested a review from Pankraty April 4, 2019 16:00
@igitur igitur added the bug label Apr 4, 2019
@Pankraty
Copy link
Member

Pankraty commented Apr 4, 2019

Why not 0.95?

@igitur
Copy link
Member Author

igitur commented Apr 4, 2019

Ok, I guess we can squeeze it in.

@igitur igitur modified the milestones: v0.96, v0.95 Apr 4, 2019
@igitur igitur merged commit e05b2a8 into ClosedXML:develop Apr 4, 2019
@igitur igitur deleted the clear-RelIds-if-loaded-from-template branch April 4, 2019 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pankraty Pankraty Pankraty approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v0.95
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igitur @Pankraty