Correctly propagate worksheet style to cells from a worksheet

[Pankraty]

As @b0bi79 has discovered, ClosedXML does not assign the worksheet style to empty cells that belong to columns or rows which had been initialized before the worksheet style was set.

        [TestCase("A1", TestName = "First cell")] // OK
        [TestCase("A2", TestName = "Cell from initialized row")]  // Fails
        [TestCase("B1", TestName = "Cell from initialized column")]  // Fails
        [TestCase("D4", TestName = "Initialized cell")]  // OK
        [TestCase("F6", TestName = "Non-initialized cell")]  // OK
        public void CellTakesWorksheetStyle(string cellAddress)
        {
            using (var wb = new XLWorkbook())
            {
                var ws = wb.AddWorksheet("Sheet1");
                ws.Column(2);
                ws.Row(2);
                ws.Cell("D4").Value = "Non empty";
                ws.Style.Font.SetFontName("Arial");
                ws.Style.Font.SetFontSize(9);

                var cell = ws.Cell(cellAddress);
                Assert.AreEqual("Arial", cell.Style.Font.FontName);
                Assert.AreEqual(9, cell.Style.Font.FontSize);
            }
        }

[b0bi79]

Alexey, I noticed that the problem recurs if the document was loaded from a file.

[Pankraty]

Please check the #1135. It addresses styles loading and may help.

[b0bi79]

It did not help. I think it need to fix this code in XLWorkbook_Load.cs method LoadColumns, line 1913:

Int32 styleIndex = col.Style != null ? Int32.Parse(col.Style.InnerText) : -1;
if (styleIndex > 0)
{
    ApplyStyle(xlColumns, styleIndex, s, fills, borders, fonts, numberingFormats);
}
else
{
    xlColumns.Style = DefaultStyle;
}

For columns that do not have their own style, the DefaultStyle is set, but there must be a sheet style.

[Pankraty]

Sounds reasonable. Will take a look at this.

[igitur]

GitHub Selfies