Enumerate ranges in a deterministic order #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Some tests are failing. |
Pankraty
changed the title
…could cause affecting the CF formula
* merged ranges are now ordered from top to bottom; * the first selected range to get active cell from is the one starting from the first row
Pankraty
changed the title
|
Fixed tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the
XLRangeIndexhad been introducedXLRangesenumeration started to return ranges in the arbitrary order which broke ranges consolidation functionality.This PR adds an ordering to the ranges enumeration and replaces and fixes #1098.