Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2020-0082: ordered_float:NotNan may contain NaN after panic in assignment operators #341

Closed
github-actions bot opened this issue Dec 7, 2020 · 3 comments · Fixed by #354
Closed

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2020

ordered_float:NotNan may contain NaN after panic in assignment operators

Details
Package ordered-float
Version 1.0.2
URL reem/rust-ordered-float#71
Date 2020-12-06
Patched versions >=1.1.1, <2.0.0,>=2.0.1
Unaffected versions <0.2.2

After using an assignment operators such as NotNan::add_assign, NotNan::mul_assign, etc., it was possible for the resulting NotNan value to contain a NaN. This could cause undefined behavior in safe code, because the safe NotNan::cmp method contains internal unsafe code that assumes the value is never NaN. (It could also cause undefined behavior in third-party unsafe code that makes the same assumption, as well as logic errors in safe code.)

This was mitigated starting in version 0.4.0, by panicking if the assigned value is NaN. However, in affected versions from 0.4.0 onward, code that uses the NotNan value during unwinding, or that continues after catching the panic, could still observe the invalid value and trigger undefined behavior.

The flaw is fully corrected in versions 1.1.1 and 2.0.1, by ensuring that the assignment operators panic without modifying the operand, if the result would be NaN.

See advisory page for additional details.

@ClementTsang
Copy link
Owner

ClementTsang commented Dec 7, 2020

From cargo-tree, the associated dependency bottom pulls that causes this is:

ordered-float v1.0.2
└── heim-process v0.0.11
    └── heim v0.0.11
        └── bottom v0.5.3 (/home/pyreko/projects/bottom)

@ClementTsang
Copy link
Owner

Would be resolved by heim-rs/heim#292.

@ClementTsang
Copy link
Owner

Instead just going to update heim to 0.1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant