Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintain v3.x line with psycopg2 support #574

Open
winglian opened this issue Mar 7, 2022 · 3 comments
Open

Maintain v3.x line with psycopg2 support #574

winglian opened this issue Mar 7, 2022 · 3 comments
Assignees
Labels

Comments

@winglian
Copy link

winglian commented Mar 7, 2022

What action do you want to perform

Since psycopg 3 isn't slated to for GA with SQLAlchemy until their 2.0 release, most users of SQLAlchemy are still using v1.4 with psycopg2. For those of us on SQLAlchemy v1.4, it doesn't really make sense to write tests with this fixture package that requires psycopg 3. Would you be open to maintaining the v3.x line please so that we can continue to get feature upgrades and fixes without the psycopg2 requirement. I'd be happy to help maintain that branch if so.

What are the results

What are the expected results

@fizyk
Copy link
Member

fizyk commented Mar 8, 2022

@winglian the latest release of https://github.com/ClearcodeHQ/pytest-postgresql/tree/v3 branch got backported support for pytest 7. (3.1.3 - https://pypi.org/project/pytest-postgresql/3.1.3/ )

I'm open to backporting fixes to v3, but won't actively pursue it. Not sure if there's something major to get backported though 🤔
The actions and branch protection rules are in place for incoming Pull requests.

@fizyk fizyk self-assigned this Mar 8, 2022
@fizyk fizyk added the question label Mar 8, 2022
@fizyk fizyk pinned this issue Mar 8, 2022
@winglian
Copy link
Author

winglian commented Mar 8, 2022

Thanks @fizyk. That was exactly what I was looking for. I assumed 3.1.2 was the end of the road for 3.x when I was looking at the changelog in main and I didn't think to look in pypi.

@fizyk
Copy link
Member

fizyk commented Mar 8, 2022

Thanks to you it'll be bit easier to find :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants