Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest 7 compatibility #376

Closed
dmkoch opened this issue Feb 6, 2022 · 2 comments
Closed

Add pytest 7 compatibility #376

dmkoch opened this issue Feb 6, 2022 · 2 comments

Comments

@dmkoch
Copy link

dmkoch commented Feb 6, 2022

What action do you want to perform

Trying to use pytest-elasticsearch==2.1.0 with pytest==7.0.0

What are the results

pytest run crashes with:

  File "/usr/local/lib/python3.9/site-packages/pytest_elasticsearch/factories.py", line 26, in <module>
    from _pytest.tmpdir import TempdirFactory
ImportError: cannot import name 'TempdirFactory' from '_pytest.tmpdir' (/usr/local/lib/python3.9/site-packages/_pytest/tmpdir.py)

What are the expected results

pytest-elasticsearch works with pytest 7.0+

dmkoch added a commit to dmkoch/pytest-elasticsearch that referenced this issue Feb 6, 2022
@fizyk
Copy link
Member

fizyk commented Feb 9, 2022

@dmkoch the tmpdir_factory fixture with tmp_path_factory fixture.

The minimum supported pytest version should then be set to 6.2
ref: ClearcodeHQ/pytest-postgresql#533

@fizyk
Copy link
Member

fizyk commented Feb 11, 2022

added

@fizyk fizyk closed this as completed Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants