Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stricter mypy configuration and annotate test functions #464

Merged
merged 1 commit into from May 31, 2021

Conversation

mmaslowskicc
Copy link
Contributor

No description provided.

@mmaslowskicc mmaslowskicc self-assigned this May 31, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #464 (eeb1c55) into master (8045efd) will decrease coverage by 0.22%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #464      +/-   ##
==========================================
- Coverage   84.16%   83.94%   -0.23%     
==========================================
  Files          22       22              
  Lines         998     1003       +5     
==========================================
+ Hits          840      842       +2     
- Misses        158      161       +3     
Flag Coverage Δ
linux 82.55% <83.33%> (-0.02%) ⬇️
macos 81.65% <83.33%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mirakuru/http.py 97.43% <ø> (ø)
tests/server_for_tests.py 0.00% <0.00%> (ø)
tests/signals.py 0.00% <0.00%> (ø)
src/mirakuru/base.py 97.61% <100.00%> (ø)
tests/executors/test_executor.py 100.00% <100.00%> (ø)
tests/executors/test_executor_kill.py 100.00% <100.00%> (ø)
tests/executors/test_http_executor.py 100.00% <100.00%> (ø)
tests/executors/test_output_executor.py 100.00% <100.00%> (ø)
tests/executors/test_pid_executor.py 100.00% <100.00%> (ø)
tests/executors/test_tcp_executor.py 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8045efd...eeb1c55. Read the comment docs.

@fizyk
Copy link
Member

fizyk commented May 31, 2021

Do you want to also add a py.typed file?

@mmaslowskicc
Copy link
Contributor Author

Do you want to also add a py.typed file?

We already install one.

@fizyk fizyk merged commit 1cf1274 into ClearcodeHQ:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants