Require Python 3.6 or newer, use f-strings and variable type annotation syntax #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix exception message accessing executor.port even for executors not having port numbers.
fizyk
approved these changes
Aug 2, 2019
| @@ -2,7 +2,6 @@ dist: xenial | |||
| language: python | |||
| conditions: v1 | |||
| python: | |||
| - 3.5 | |||
| - 3.6 | |||
| - 3.7 | |||
There was a problem hiding this comment.
could you try if there's 3.8 available already?
There was a problem hiding this comment.
It's available, while a test fails due to the fix for https://pagure.io/python-daemon/issue/34 not being released. Should I add 3.8 and xfail the affected tests on that version?
There was a problem hiding this comment.
There was a problem hiding this comment.
or the xfail indeed with failing test while it starts passing.
fizyk
approved these changes
Aug 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #314