Skip to content

fix(tx): fix WitnessRule and WitnessCondition deserialization #873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix(tx): fix WitnessRule and WitnessCondition deserialization #873

merged 1 commit into from
Nov 7, 2022

Conversation

ixje
Copy link
Member

@ixje ixje commented Nov 4, 2022

fixes #872

  • WitnessRule deserialization failed because the type had to be converted to int first
  • BooleanAndCondition deserialization failed because !!"00" evaluated to true not false.
  • AndCondition deserialization failed because this was undefined when called here
    const implementingClass = this.getImplementation(witnessType);

@ixje ixje requested a review from snowypowers November 4, 2022 10:31
@ixje ixje merged commit a7bd378 into CityOfZion:dev Nov 7, 2022
@ixje ixje deleted the fix-witnessrules branch November 7, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants