From b0fe34aea36ac95a73797d2bfe0e393020ea045f Mon Sep 17 00:00:00 2001 From: Gene Hoffman Date: Mon, 28 Mar 2022 13:07:42 -0700 Subject: [PATCH 1/2] Correctly handle fallback_version --- pyproject.toml | 1 + setup.py | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index c320f0e0..9aa80285 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -3,4 +3,5 @@ requires = ["setuptools>=42", "wheel", "setuptools_scm[toml]>=3.5.0", "pybind11" build-backend = "setuptools.build_meta" [tool.setuptools_scm] +fallback_version = "unknown-no-.git-directory" local_scheme = "no-local-version" diff --git a/setup.py b/setup.py index 9c73a4a3..8c9b7400 100644 --- a/setup.py +++ b/setup.py @@ -280,5 +280,4 @@ def build_extensions(self): build_ext=CMakeBuild, install_hook=install_hook, build_hook=build_hook ), zip_safe=False, - use_scm_version={"fallback_version": "unknown-no-.git-directory"}, ) From 5b7ca9c9d7b5c1a2d8fe15c826446e69636f6169 Mon Sep 17 00:00:00 2001 From: Gene Hoffman Date: Mon, 28 Mar 2022 15:46:03 -0700 Subject: [PATCH 2/2] Totally forgot about the horrible windows workaround hack. --- setup.py | 1 - 1 file changed, 1 deletion(-) diff --git a/setup.py b/setup.py index 8c9b7400..e84f7fdc 100644 --- a/setup.py +++ b/setup.py @@ -258,7 +258,6 @@ def build_extensions(self): ext_modules=ext_modules, cmdclass={"build_ext": BuildExt}, zip_safe=False, - use_scm_version={"fallback_version": "unknown-no-.git-directory"}, ) else: build.sub_commands.append(("build_hook", lambda x: True)) # type: ignore