Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix case where k=0, which happens in tests #79

Merged
merged 1 commit into from May 13, 2021
Merged

fix case where k=0, which happens in tests #79

merged 1 commit into from May 13, 2021

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented May 13, 2021

this fixes a division by zero in the tests (because k = 0) and this expression:

ceil(1.0 * num_iterations / (k * l))

Invokes UB. On ARM, this would manifest as the loop not terminating (because the end condition was "infinite"), and it would then access an uninitialized form object from the end of intermediates

@arvidn arvidn requested review from fchirica and wjblanke May 13, 2021 12:58
@arvidn arvidn mentioned this pull request May 13, 2021
Closed
wjblanke
wjblanke approved these changes May 13, 2021
View reviewed changes
Copy link
Contributor

@wjblanke wjblanke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aok

@wjblanke wjblanke merged commit f9b8c93 into main May 13, 2021
@wjblanke wjblanke deleted the fix-k-zero branch May 13, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjblanke wjblanke wjblanke approved these changes

@fchirica fchirica fchirica approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arvidn @wjblanke @fchirica