Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly handle fallback_version #110

Merged
merged 2 commits into from Mar 28, 2022
Merged

Correctly handle fallback_version #110

merged 2 commits into from Mar 28, 2022

Conversation

hoffmang9
Copy link
Member

This will stop testpypi uploads from failing in CI

altendky
altendky requested changes Mar 28, 2022
View reviewed changes
setup.py Show resolved Hide resolved
@hoffmang9 hoffmang9 requested a review from altendky March 28, 2022 22:46
altendky
altendky approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@altendky altendky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending CI

@hoffmang9 hoffmang9 merged commit 5fa030f into main Mar 28, 2022
@hoffmang9 hoffmang9 deleted the unk-version branch March 28, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aqk aqk aqk approved these changes

@altendky altendky altendky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hoffmang9 @aqk @altendky