New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename rather than copy if tmp2 filename is on the same device as final filename #313
Comments
PR ready (#314) if/when someone has time to approve it. Thanks. |
'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.' |
'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.' |
Not stale, waiting on #314 |
'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.' |
Not stale, waiting on #314 |
This is an ongoing irritation in my environment. Can I help in any way getting #314 testing completed so it can be merged? |
'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.' |
Not stale, still need #314 merged. |
'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.' |
Not stale, still needs merge. |
'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.' |
Still waiting. @hoffmang9 , can someone get this in please? |
We'll put this into 1.3 beta so we can get a better idea of how it works in practice with different drives, devices, os, mount point, etc. Need to do another chiapos release then merge into main |
Drawing this over from Chia-Network/chia-blockchain#8847 -
When tmp and final files are in different directories on the same device, the code doesn't know that it can perform a rename(), and instead spends a lot of time unnecessarily copying the file data.
The text was updated successfully, but these errors were encountered: