Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trade_record status clarification requested #420

Open
KryptomineCH opened this issue Nov 10, 2023 · 1 comment
Open

trade_record status clarification requested #420

KryptomineCH opened this issue Nov 10, 2023 · 1 comment

Comments

@KryptomineCH
Copy link
Contributor

KryptomineCH commented Nov 10, 2023

I would like to request some documentation improvements or alternatively explanations on trade_record of an offer File.

I am trying to make sense of the following trade_record:
image

- accepted_at_time = null // indicates to me the offer has not been accepted
- confirmed_at_index = 0 // indicates to me the offer has not been accepted
- pending = 1 // seems to be only half of the offer. Cant really make sense of that`- awaiting accept?
- sent_to = 0 // probably empty because I created the offer??
- status = CONFIRMED // indicates to me that the offer was accepted

Is it confirmed (executed), pending (awaiting accept), pending (awaiting transaction), or nothing at all (since not sent to blockchain) ??

@KryptomineCH KryptomineCH changed the title trade_record status trade_record status clarification requested Nov 10, 2023
@BrandtH22
Copy link
Collaborator

Hey @KryptomineCH , yes it seems you have interpreted all of this correctly. I believe the sent_to might be related to sending onchain notifications for offer files (currently tied to having an NFT included in the offer file and the notification is sent to the xch address that owns the nft).

Were there any other questions regarding this? (note I am also working on the other transaction issue reported and making sure your excellent notes are added to the docs site)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants