Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rework build matrix to a single workflow #338

Merged
merged 7 commits into from Aug 11, 2022
Merged

rework build matrix to a single workflow #338

merged 7 commits into from Aug 11, 2022

Conversation

altendky
Copy link
Contributor

@altendky altendky commented Jul 10, 2022

This closely follows the form of Chia-Network/chiavdf#118.

Ideas:

  • Can we centralize the build of gmp?
  • Can we agree on either src/lib/ or contrib/ between here and chiavdf?

Draft for:

  • We are not patching with src/lib/gmp-patch-6.2.1/mpz/inp_raw.c, is that ok?
  • Are the sha256 hashes required? I don't recall seeing them elsewhere.

@hoffmang9
Copy link
Member

The hashes were a start at the upstream repos confirming them. The main repo is publishing a package hash now and we're pinning to version so probably ok to drop for now

@altendky
Copy link
Contributor Author

I have no problem putting them in, but in so much as we 'need' them we should do it everywhere I would think. I'll leave them out for now but would be happy to bring them back someday. Maybe as an action to process a GitHub Actions artifact of all the packages?

@altendky altendky mentioned this pull request Jul 11, 2022
1 task
@altendky altendky marked this pull request as ready for review August 11, 2022 01:24
@cmmarslender cmmarslender merged commit 74e0dac into main Aug 11, 2022
@cmmarslender cmmarslender deleted the ragged_matrix branch August 11, 2022 14:05
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Sep 6, 2022
* rework build matrix to a single workflow

* rm the others

* debug

* drop the inp_raw.c patch

* try dropping CIBW_ENVIRONMENT_WINDOWS

* just remove it

* Revert "debug"

This reverts commit 7a2e1af.
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Sep 6, 2022
* rework build matrix to a single workflow

* rm the others

* debug

* drop the inp_raw.c patch

* try dropping CIBW_ENVIRONMENT_WINDOWS

* just remove it

* Revert "debug"

This reverts commit 7a2e1af.
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Sep 6, 2022
* rework build matrix to a single workflow

* rm the others

* debug

* drop the inp_raw.c patch

* try dropping CIBW_ENVIRONMENT_WINDOWS

* just remove it

* Revert "debug"

This reverts commit 7a2e1af.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants