Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build on main, tags, and PRs #293

Merged
merged 1 commit into from Dec 3, 2021
Merged

Build on main, tags, and PRs #293

merged 1 commit into from Dec 3, 2021

Conversation

altendky
Copy link
Contributor

As is this builds on any push and also any PR. This results in double workflows on PRs.

As is this builds on any push and also any PR.  This results in double
workflows on PRs.
@altendky
Copy link
Contributor Author

When reviewing, please consider how releases are done. I do not know this process and as such don't know how it might affect it. Mostly this should just stop the double builds and add builds on tags.

@altendky altendky marked this pull request as ready for review November 13, 2021 23:57
Copy link
Contributor

@cmmarslender cmmarslender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok to me - I think the only real change here is just not running on pushes to branches other than main without a PR being open - otherwise, should run in all the existing cases.

@altendky
Copy link
Contributor Author

That, plus it will run on tags.

@cmmarslender
Copy link
Contributor

That, plus it will run on tags.

Should have already been running on tags, since tags is within push, and push (with no further restrictions) was already selected before (this is also how releases happen - when the event was for a tag push)

@wjblanke wjblanke merged commit 6385ba2 into main Dec 3, 2021
@wjblanke wjblanke deleted the build_on_main_tags_prs branch December 3, 2021 19:31
UdjinM6 pushed a commit to UdjinM6/bls-signatures that referenced this pull request Sep 6, 2022
As is this builds on any push and also any PR.  This results in double
workflows on PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants