Bug: invalid G1 and G2 cached in PrivateKey #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano54
approved these changes
Nov 10, 2021
furszy
added a commit
to PIVX-Project/bls-signatures
that referenced
this pull request
Nov 26, 2021
183be27 BugFix: Invalidate caches in PrivateKey copy assignment operator (random-zebra) 4272466 QA: test cache invalidation for PrivateKey copy assignment operator (random-zebra) Pull request description: Pretty serious bug in the copy-assignment operator, discovered after a long investigation with @furszy over an intermittent failure in a unit test for deterministic masternodes in Core. For reference, pull request submitted upstream: Chia-Network#289 ACKs for top commit: furszy: obvious ACK 183be27 🤘 . Tree-SHA512: 2d43ed6bbfb761df889a8b6b563cd5e3ef103632941dcb96220bf6695e881ffccae29e66640bcd32262d2886e4858fc745d373fad413c3a4dcb2a90a3b9a7d0b
UdjinM6
pushed a commit
to UdjinM6/bls-signatures
that referenced
this pull request
Dec 1, 2021
* QA: test cache invalidation for PrivateKey copy assignment operator * BugFix: Invalidate caches in PrivateKey copy assignment operator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #168.
The copy assignment operator does not invalidate the caches.
This could dangerously lead to situations where a
PrivateKeyreturns wrong G1/G2 elements (if they were cached before the copy).