Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

**[Caution]** NPM package currently in public is unknown 0.2.5 version #234

Closed
ChiaMineJP opened this issue Jun 16, 2021 · 31 comments
Closed
Assignees

Comments

@ChiaMineJP
Copy link
Contributor

The problem

If you install bls-signatures via npm install bls-signature, you will install bls-signatures of version 0.2.5,
whose source code has not yet been published to this repository.
https://www.npmjs.com/package/bls-signatures
Maybe a developer built and published its private source code into the npm registry.

I cannot say it is untrusted because the one who published the 0.2.5 version of the npm package is one of the original authors.

But in the world of crypto currency, it requires extreme level of transparency.
The npm package published to the npm registry should be synced to the source code publicly available by this repository.

Note

Anyone who wants to install the latest package including fixed js-typings which is recently committed, please go visit my forked repository.

@tiantianlikeu
Copy link

I have a this problem

@hoffmang9
Copy link
Member

The version in npm is a legitimate js binding of bls-signatures from before it was modified to be fully IETF BLS compliant. It is totally out of date. We are currently working on getting a new release into npm and should have that complete in the next few days.

@tiantianlikeu
Copy link

@hoffmang9 ok ,thanks

@tiantianlikeu
Copy link

@hoffmang9 Hello, Are U sleep? I has a new problem, Do you consider adding mnemonic genration and mnemonic import in the new version?

@ChiaMineJP
Copy link
Contributor Author

ChiaMineJP commented Jul 13, 2021

@hoffmang9
Let me help you.
If you have a plan for js-bidings, please provide it to me.
I'll create some PR for it.

Current situation

js typings was fixed by my past PR and old test specs are also updated to the latest in #242
So publishing new npm package is almost ready to go.

What's remaining

@tiantianlikeu
Copy link

@hoffmang9 hello ,when can release bls-sign for npm?

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue was automatically closed because it has been flagged as stale and subsequently passed 7 days with no further activity.'

@ChiaMineJP
Copy link
Contributor Author

This ticket should not be closed.

@hoffmang9 hoffmang9 reopened this Aug 19, 2021
@ChiaMineJP
Copy link
Contributor Author

Oh god! You haven't forgot this issue!

@github-actions
Copy link

github-actions bot commented Sep 4, 2021

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@ChiaMineJP
Copy link
Contributor Author

Bump. I still want to contribute to this project, if you allow me.

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

github-actions bot commented Oct 4, 2021

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@taro199
Copy link

taro199 commented Oct 17, 2021

Don't go stale

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

github-actions bot commented Feb 5, 2022

'This issue was automatically closed because it has been flagged as stale and subsequently passed 7 days with no further activity.'

@github-actions github-actions bot closed this as completed Feb 5, 2022
@ChiaMineJP ChiaMineJP reopened this Feb 5, 2022
@github-actions
Copy link

'This issue was automatically closed because it has been flagged as stale and subsequently passed 7 days with no further activity.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@github-actions
Copy link

'This issue has been flagged as stale as there has been no activity on it in 14 days. If this issue is still affecting you and in need of review, please update it to keep it open.'

@hoffmang9
Copy link
Member

And finally addressed by #335

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants