From 0dfd8b6415670608d60523fb4de3022d8c676096 Mon Sep 17 00:00:00 2001
From: dustinface <35775977+xdustinface@users.noreply.github.com>
Date: Wed, 8 Sep 2021 19:34:57 +0200
Subject: [PATCH] Revert "python-bindings: Add `pickle` support for `G1Element`
 (#265)" (#278)

This reverts commit 616230cefa8135e72607d196e749c6ffb517bd4c.
---
 python-bindings/pythonbindings.cpp | 10 ----------
 python-bindings/test.py            | 14 --------------
 2 files changed, 24 deletions(-)

diff --git a/python-bindings/pythonbindings.cpp b/python-bindings/pythonbindings.cpp
index c1da1a127..990f87c2f 100644
--- a/python-bindings/pythonbindings.cpp
+++ b/python-bindings/pythonbindings.cpp
@@ -373,16 +373,6 @@ PYBIND11_MODULE(blspy, m)
                 // PythonGIL release_lock;
                 return G1Element::FromBytes(Bytes(data_ptr, G1Element::SIZE));
             })
-        .def(py::pickle(
-        [](const G1Element &dp) { // __getstate__
-            return py::make_tuple(dp.Serialize());
-            },
-            [](py::tuple t) { // __setstate__
-            if (t.size() != 1)
-                throw std::runtime_error("Invalid state!");
-            auto vecBytes = t[0].cast<std::vector<uint8_t>>();
-            return G1Element::FromByteVector(vecBytes);
-        }))
         .def("generator", &G1Element::Generator)
         .def("from_message", py::overload_cast<const std::vector<uint8_t>&, const uint8_t*, int>(&G1Element::FromMessage))
         .def("pair", &G1Element::Pair)
diff --git a/python-bindings/test.py b/python-bindings/test.py
index 2d93043c2..8fe58f0d1 100644
--- a/python-bindings/test.py
+++ b/python-bindings/test.py
@@ -1,6 +1,5 @@
 # flake8: noqa: E501
 import binascii
-import pickle
 from copy import deepcopy
 
 from blspy import (
@@ -336,24 +335,11 @@ def test_aggregate_verify_zero_items():
     assert AugSchemeMPL.aggregate_verify([], [], G2Element())
 
 
-def test_pickle_support():
-    seed = bytes([
-        0, 50, 6, 244, 24, 199, 1, 25, 52, 88, 192, 19, 18, 12, 89, 6,
-        220, 18, 102, 58, 209, 82, 12, 62, 89, 110, 182, 9, 44, 20, 254, 22
-    ])
-    key: PrivateKey = AugSchemeMPL.key_gen(seed)
-    g1: G1Element = key.get_g1()
-    g1_data = pickle.dumps(g1)
-    g1_restored = pickle.loads(g1_data)
-    assert g1 == g1_restored
-
-
 test_schemes()
 test_vectors_invalid()
 test_vectors_valid()
 test_readme()
 test_aggregate_verify_zero_items()
-test_pickle_support()
 
 print("\nAll tests passed.")