[RFC] Suggest to have more detailed error message when doing ContactSelf related operations

[windmemory]

Today I found that people are complaining about wechaty logout operation throw errors. I dig into the log and find that, some operations on the ContactSelf was triggered, and since the bot is logged out, error thrown out.

Here is the code in wechaty-puppet that trigger the error:

public selfId (): string {
  log.verbose('Puppet', 'selfId()')

  if (!this.id) {
    throw new Error('not logged in, no this.id yet.')
  }

  return this.id
}

It's totally okay for it throw such error message out, but when using it in wechaty, like this:

public async qrcode (): Promise<string> {
  log.verbose('Contact', 'qrcode()')

  if (this.id !== this.puppet.selfId()) {
    throw new Error('only can get qrcode for the login userself')
  }

  const qrcodeValue = await this.puppet.contactSelfQrcode()
  return qrcodeValue
}

An error with message not logged in, no this.id yet. will be printed out in the console, and to whom are writing bot with wechaty, they will treat this error message as "system message" (which means thrown out by wechaty and should be handled by wechaty)

So I suggest to have a better error message here, to indicate that what operation failed and for what reason that the operation failed. I will submit a PR later to illustrate my proposal.

[huan]

Good catch and nice fix.

Merged!

[windmemory]

Thanks for the merging!