lodestar-validator missing @chainsafe/lodestar-db dependency

[mpetrunic]

Describe the bug

Missing @chainsafe/lodestar-db dependency dependency in package.json

Expected behavior

For dependency to list and auto install.
We had eslint rule that was checking those things. Seems like it stopped working.

Steps to Reproduce

Screenshots

Desktop (please complete the following information):

• OS:
• Version:
• Branch:
• Commit hash:

[3xtr4t3rr3str14l]

so, i tried modifying the existing entry we have for import/no-extraneous-dependencies eslintrc.js in the monorepo root with the following:

"import/no-extraneous-dependencies": ["error", {
      "devDependencies": true,
      "optionalDependencies": false,
      "peerDependencies": false,
      "packageDir": ['./', '../../'],
    }],

as well as commenting out this line (in order to turn the rule back on):

lodestar/.eslintrc.js

Line 93 in 5162c91

"import/no-extraneous-dependencies": "off",

The above won't throw a linting error when @chainsafe/lodestar-db is missing from the package.json. However, when I tried to remove the @chainsafe/bls package from the lodestar-validator package.json, it did trigger a linting error for the above rule. BUT, when I tried to remove @chainsafe/lodestar-beacon-state-transition from package.json, it did not trigger a linting error.

So, it looks to me like we maybe we would have to modify the eslint rules somehow to allow monorepo sibling packages to be considered extraneous packages during linting, which I'm not sure how to do at the moment. I tried looking for a little bit, but couldn't find anything off hand. Open to suggestions if anyone knows how to do this.

We had eslint rule that was checking those things. Seems like it stopped working.

@mpetrunic , when you say this, do you mean that the eslint rule we used to have also checked for missing dependencies that are also monorepo sibling packages?

[mpetrunic]

That plugin worked for that before.

devDependencies: true should only be set in test files.

I bet it's error with packageDir, potential solution:
import-js/eslint-plugin-import#1174 (comment)

[dapplion]

Fixed

lodestar/packages/lodestar-validator/package.json

Line 50 in 4a014f0

"@chainsafe/lodestar-db": "^0.17.0",