chore: Fix signature validation bug #130
Merged
+4
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
requested review from
wemeetagain,
twoeths and
dapplion
as code owners
wemeetagain
reviewed
Mar 9, 2022
wemeetagain
reviewed
Mar 9, 2022
| @@ -15,7 +15,8 @@ describe('IK Handshake', () => { | |||
| [peerA, peerB] = await createPeerIdsFromFixtures(3) | |||
| }) | |||
|
|
|||
| it('should finish both stages as initiator and responder', async () => { | |||
| // IK handshake is not used, no idea why this test isn't passing but it makes no sense to debug until we start using it | |||
There was a problem hiding this comment.
Can you make an issue about this so we don't forget
Closed
wemeetagain
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.