Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for module file renderer #10000

Open
jonathon-love opened this issue Aug 2, 2022 · 2 comments
Open

update for module file renderer #10000

jonathon-love opened this issue Aug 2, 2022 · 2 comments
Labels

Comments

@jonathon-love
Copy link

hi,

i've opened a quite simple PR over here several weeks ago.

is osf still being actively maintained, or do i need to temper my expectations?

with thanks

@jwalz
Copy link
Collaborator

jwalz commented Aug 2, 2022

Sorry about that, MFR doesn't always get as much attention as other parts of our codebase. Tagging @felliott to take a look, but seems non-controversial to me. Also, congrats on (unintentionally) swiping issue #10000 from us and guaranteeing you got our attention 😂

Thanks for the contribution!

@cslzchen
Copy link
Contributor

cslzchen commented Aug 2, 2022

Follow-up: @felliott is out and I just did a CR, it looks great with one nitpick which is to update unit tests, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants