Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create subfolder in default directory by default #764

Open
xeruf opened this issue Mar 17, 2021 · 4 comments
Open

Create subfolder in default directory by default #764

xeruf opened this issue Mar 17, 2021 · 4 comments

Comments

@xeruf
Copy link
Contributor

xeruf commented Mar 17, 2021

Description of the issue

When I select the default directory as a directory for a new synced folder, the app syncs right into that folder, which doesn't seem to make sense since I can then not reasonably add any more directories into it.

Expectation

The app creates and syncs to a subdirectory with the name of the share if I select the default directory.

Version Information

  • App Version: 1.13.1.1
  • Syncthing Version: v1.13.1
  • Android Version: Android 8.0.0
  • Device manufacturer: Samsung
  • Device model: S7
@Catfriend1
Copy link
Owner

Catfriend1 commented Mar 17, 2021

Hi,

would you be willing to work on this and write SAF code and the necessary access checks that ensures the Syncthing native has access to the subfolder? Android apps only create folders with scoped access by Uris if the user does consent access.

@Catfriend1
Copy link
Owner

This seems to be better idea after #763

@JohnVeness
Copy link
Contributor

Although I understand the frustration of the original poster, I would want this to be optional! If I create (in a file manager, say) a folder called "Passwords" then choose that folder while setting up Syncthing, I would want my files to be synced there, not in a folder called "Passwords/Passwords".

Maybe what is really needed is a clear indication in advance of whether or not a subfolder will be created, so the user will understand better what is being configured.

@xeruf
Copy link
Contributor Author

xeruf commented Aug 10, 2021

Although I understand the frustration of the original poster, I would want this to be optional! If I create (in a file manager, say) a folder called "Passwords" then choose that folder while setting up Syncthing, I would want my files to be synced there, not in a folder called "Passwords/Passwords".

You are misunderstanding the proposal. If you select a folder, it should sync directly into that folder. But if you stay with the default folder, it should automatically create a subdir, because your default folder would become useless as default if something syncs right into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants