Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forced run - split head, make clear "UI" vs. "daemon" #1040

Open
licaon-kter opened this issue Nov 20, 2023 · 14 comments
Open

Forced run - split head, make clear "UI" vs. "daemon" #1040

licaon-kter opened this issue Nov 20, 2023 · 14 comments
Labels

Comments

@licaon-kter
Copy link
Contributor

licaon-kter commented Nov 20, 2023

...forced start is not doing what's expected, the UI messages are confused/ing.

1.26.0.2 F-Droid

The Status UI page says: "Syncthing is not running" and lower "reason: Syncthing is running because you forced it to start regardless..."

No sync happens though.

188a1c25_C5ujqPtHSyqY6G8Cp3qx7g

To fix it I need to exit it, then restart it.

@licaon-kter
Copy link
Contributor Author

Attached picture to OP

@Catfriend1
Copy link
Owner

@licaon-kter

Is the screenshot above the result of the native crashing? This was reported since v1.26.x releases and upstream has merged a PR to fix this, hopefully to be released soon. I agree the messages are weird, but regarding that the native crashing should not be daily matter, I suggest it's okay.

The message "Syncthing is not running" is sent by the native executor which also detects the crash.
The message in the "reason" section is just to sum up the set run conditions. Confusing yes, but at least we now know why it is ;-).

Maybe we could hide the reasons if a crash was detected.

@licaon-kter
Copy link
Contributor Author

I don't see visible Android crashes, so if it's the daemon under the hood I'd need to check logcat.

@licaon-kter
Copy link
Contributor Author

licaon-kter commented Nov 22, 2023

oh so you have in app logging, will capture one of those when it happens again (of course I tried now and it didn't crash)

fyi, when testing before, I needed to press restart or kill 2-3 times until it actually was able to start :(

@Catfriend1
Copy link
Owner

@licaon-kter you could also try the latest preview build from the github release page . It contains upstream's fix.

@EuPhobos
Copy link

After last update this also happens to me too. Syncthing-fork not working anymore for me. Even if device on AC.

@Catfriend1
Copy link
Owner

@EuPhobos try preview?

@EuPhobos
Copy link

EuPhobos commented Nov 23, 2023

@Catfriend1 yep, trying this file com.github.catfriend1.syncthingandroid_github_v1.26.1.0_2ee4de2c.apk, same problem.
Before i has f-droid version running fine, today i update app and faced with a this problem.
I export settings, remove f-droid verion, install github version, import settings - same problem.
I can provide logs, if you need.

@Catfriend1
Copy link
Owner

@EuPhobos

There is a newer release 1.27.0.0

@EuPhobos
Copy link

@Catfriend1 Oh, my inattention.
1.27 work fine now. Thank you very much! You're best

@Catfriend1
Copy link
Owner

Thanks for reporting back

@Catfriend1
Copy link
Owner

I think this is okay for me, let the head split when the native crashes. If this ever happens, the user is doomed and other parts of the app may also be inaccurate or non-working.

@Catfriend1
Copy link
Owner

For correctness: it gets a verified bug label 😊

@licaon-kter
Copy link
Contributor Author

licaon-kter commented Nov 23, 2023

let the head split when the native crashes.

No problem with that, maybe rework the strings a bit to separate "UI" vs "daemon" so they don't both identify themselves as "Syncthing"?

@Catfriend1 Catfriend1 reopened this Nov 23, 2023
@Catfriend1 Catfriend1 changed the title Forced run - split head Forced run - split head, make clear "UI" vs. "daemon" Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants